From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B328AA04B7;
	Tue, 13 Oct 2020 14:34:32 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5242C1DAD0;
	Tue, 13 Oct 2020 14:34:31 +0200 (CEST)
Received: from out0-147.mail.aliyun.com (out0-147.mail.aliyun.com
 [140.205.0.147]) by dpdk.org (Postfix) with ESMTP id 33FE61DAC2
 for <dev@dpdk.org>; Tue, 13 Oct 2020 14:34:26 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=alibaba-inc.com; s=default;
 t=1602592461; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type;
 bh=x/s4sBT1iMucixtNJsLopxUV/2h6cx1BI+C+rPjtvjs=;
 b=RO4v5SpOA508gYkicMdx6TEI7y509ANi8g4FFls/ESYTPGhplVYluq+6F3h9oqqMPBc23hB8qOmM2mhv+YInysaUcgfxJ4DHLY/z6hZzrVAU47szVS3U60L4mYrEUovMbyqqFwh6uiZstXv8o2C+fpWPb700N2lx9bwo+iv0mm8=
X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R141e4; CH=green; DM=||false|;
 DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018047203;
 MF=huawei.xhw@alibaba-inc.com; NM=1; PH=DS; RN=2; SR=0;
 TI=SMTPD_---.IiaRoLB_1602592460; 
Received: from 30.43.67.120(mailfrom:huawei.xhw@alibaba-inc.com
 fp:SMTPD_---.IiaRoLB_1602592460) by smtp.aliyun-inc.com(127.0.0.1);
 Tue, 13 Oct 2020 20:34:21 +0800
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev <dev@dpdk.org>
References: <68ecd941-9c56-4de7-fae2-2ad15bdfd81a@alibaba-inc.com>
 <1602578499-13975-1-git-send-email-huawei.xhw@alibaba-inc.com>
 <1602578499-13975-2-git-send-email-huawei.xhw@alibaba-inc.com>
From: "=?UTF-8?B?6LCi5Y2O5LyfKOatpOaXtuatpOWIu++8iQ==?="
 <huawei.xhw@alibaba-inc.com>
Message-ID: <28ded194-2f2e-3778-bdd2-197f2ccace84@alibaba-inc.com>
Date: Tue, 13 Oct 2020 20:34:00 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.2
MIME-Version: 1.0
In-Reply-To: <1602578499-13975-2-git-send-email-huawei.xhw@alibaba-inc.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v4] pci: support both PIO and MMIO BAR for
 legacy virtio on x86
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


>   	switch (p->dev->kdrv) {
>   #ifdef VFIO_PRESENT
>   	case RTE_PCI_KDRV_VFIO:
> -		pci_vfio_ioport_read(p, data, len, offset);
> +		pci_uio_ioport_read(p, data, len, offset);
>   		break;
>   #endif
>   	case RTE_PCI_KDRV_IGB_UIO:
> -		pci_uio_ioport_read(p, data, len, offset);
> -		break;
>   	case RTE_PCI_KDRV_UIO_GENERIC:
>   		pci_uio_ioport_read(p, data, len, offset);
>   }


Maxime:

With this patch, virtio PIO/MMIO port RW is directly through user space 
instruction instead of vfio ioctl syscall.

/huawei