From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11C49A053D; Wed, 5 Aug 2020 17:15:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A81F92BF2; Wed, 5 Aug 2020 17:15:35 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id B5259E07; Wed, 5 Aug 2020 17:15:34 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6074D5C00F5; Wed, 5 Aug 2020 11:15:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 05 Aug 2020 11:15:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= VfuzzJEnlqtdQG3MBllTPmmChwKboSIOYnnAxlxsR3E=; b=xFnw3ChE1lqx7uiw hTJDKh4yA22fLtjorp8WqUcw+fS7F3yJU90v28w+xp9wS5iFyN7a5uIcZ04gwDwu 29PKCGcxAxIM+2JlqkmcqLNOc0tnF9FH2TpS4lPYOaCbiwNFUqIW9yKeonDSNDAz DopOdIcXzIdc5gdpHTqs0AAuR+emvo7mOgXREjX4W55MlLDGJ1Jo3tXo8YZTFbaY bFi4Bp+bXyl9k8HzXc1HE0zkwqlhf+pfrCvq/pGqDU2tCHqP87J2vydZ8AwMHKBf HsF9HQAsg1bWpGOFrJN4svEvK4ymfr+EY6SKMFgJJYXUhgTENGCKVzn6Q3nc3A2I T0DvFQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=VfuzzJEnlqtdQG3MBllTPmmChwKboSIOYnnAxlxsR 3E=; b=p8csuieAyRLzyeKL6qzZVhMzgTUUiCABuUcpVn47xsBx2cHOtSWPLjJEZ 6inMtxRQkZY5rFVzLZg49+T4HZ2JubedtIes6/X70C6bRrHhvphI/rAKhY2Qr8Jl YZ4Vq98R4+1sMgdOvF2I0kwHXSDs34r6912boO/9BJIjqnYmkfqiIfZ1NyB1VB9d ybf68g2YPfhfrnnVtH3pngtWBTAsjdgxOfYTpkzFLOP4fRCYw97j05/2aRDL3XWl Nk+fJqMaXa2tJrpm9K6IKQuOBTAF1+5loclALtFJlZh7vcGVV03xIc19P8Wm5i79 52p19ZdA1lmVZcx6Jba1UwT8jvLnw== X-ME-Sender: <xms:Fc0qXy6zP_bjzCdqhT5UOIsEd561RpeImQaphFTJ_5eeCiieZk2m_w> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: <xmx:Fc0qX766eG5r2Ssjj5H2GyfLyRaqV_L9vkSZUDD4nwYHVQxwjrwaUA> <xmx:Fc0qXxePtmO2-G4_R4P-vzVdEldL5nZmKnua82XqNSe4VCuZfsjcfg> <xmx:Fc0qX_ICYZkxuGWlJ4g_4Gz_0IYvqL-4JcksrsisYDwZbS7PQj7gCA> <xmx:Fs0qX1lHxqhhy44cgHrjDGzM4pV3eK6Wuq7bgOVJkha2Lp4lhvJHRA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 523A730600A9; Wed, 5 Aug 2020 11:15:33 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org, techboard@dpdk.org Date: Wed, 05 Aug 2020 17:15:31 +0200 Message-ID: <2902184.3RBbl2PCEx@thomas> In-Reply-To: <20200805150741.GD1716@bricha3-MOBL.ger.corp.intel.com> References: <20200805142141.32337-1-bruce.richardson@intel.com> <2844470.HTv9E7uqEf@thomas> <20200805150741.GD1716@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH 1/1] doc: add deprecation notice for CPU build flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 05/08/2020 17:07, Bruce Richardson: > On Wed, Aug 05, 2020 at 04:57:42PM +0200, Thomas Monjalon wrote: > > 05/08/2020 16:21, Bruce Richardson: > > > The RTE_MACHINE_CPUFLAGS_* macros in DPDK build just duplicate info from > > > the compiler macros, so we can remove them and just use the compiler > > > versions directly. > > > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > > --- > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > +* build macros: The macros defining RTE_MACHINE_CPUFLAG_* will be removed > > > + from the build. The information provided by these macros is available > > > + through standard compiler macros. For example, RTE_MACHINE_CPUFLAG_SSE3 > > > + duplicates the compiler-provided macro __SSE3__. > > > > I see 2 advantages of having alias: > > - if 2 compilers differ, we can manage > > - we can find all such macros with grep RTE_MACHINE_CPUFLAG > > > > Sure, if you think it's worthwhile keeping them, we can do so. It's just > right now they seem to be largely a waste of space. For #2, I'm not sure > when we would want to grep for them all, except possibly to remove them. > :-) For instance, in a lib, I grep where we have CPU specific code. We probably need more opinions, I can change my mind.