From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: John Ousterhout <ouster@cs.stanford.edu>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] log: respect rte_openlog_stream calls before rte_eal_init
Date: Wed, 12 Oct 2016 21:47:32 +0200 [thread overview]
Message-ID: <2906824.LEp5vtMuTD@xps13> (raw)
In-Reply-To: <20161012193832.5016-1-ouster@cs.stanford.edu>
2016-10-12 12:38, John Ousterhout:
> @@ -127,6 +125,19 @@ rte_vlog(uint32_t level, uint32_t logtype, const char *format, va_list ap)
> {
> int ret;
> FILE *f = rte_logs.file;
> + if (f == NULL) {
> + f = default_log_stream;
> + if (f == NULL) {
> + /*
> + * Grab the current value of stderr here, rather than
> + * just initializing default_log_stream to stderr. This
> + * ensures that we will always use the current value
> + * of stderr, even if the application closes and
> + * reopens it.
> + */
> + f = stderr;
> + }
> + }
I don't understand this big comment.
What is the difference with initializing default_log_stream to stderr?
What do you mean by "if the application closes and reopens it"?
next prev parent reply other threads:[~2016-10-12 19:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 20:42 [dpdk-dev] [PATCH] " John Ousterhout
2016-09-30 15:01 ` Thomas Monjalon
2016-10-10 22:39 ` [dpdk-dev] [PATCH v2] " John Ousterhout
2016-10-11 8:08 ` Thomas Monjalon
2016-10-11 16:30 ` John Ousterhout
2016-10-11 20:30 ` Thomas Monjalon
2016-10-11 21:46 ` John Ousterhout
2016-10-12 7:09 ` Thomas Monjalon
2016-10-11 22:16 ` Don Provan
2016-10-12 0:22 ` John Ousterhout
2016-10-12 19:29 ` [dpdk-dev] [PATCH v3] " John Ousterhout
2016-10-12 19:38 ` [dpdk-dev] [PATCH v4] " John Ousterhout
2016-10-12 19:47 ` Thomas Monjalon [this message]
2016-10-12 21:17 ` John Ousterhout
2016-10-13 20:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2906824.LEp5vtMuTD@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ouster@cs.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).