DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Xiaoyun Li <xiaoyun.li@intel.com>
Cc: dev@dpdk.org, zhihong.wang@intel.com,
	konstantin.ananyev@intel.com, bruce.richardson@intel.com,
	wenzhuo.lu@intel.com, helin.zhang@intel.com,
	ophirmu@mellanox.com
Subject: Re: [dpdk-dev] [PATCH] eal/x86: revert select optimized memcpy at run-time
Date: Tue, 07 Nov 2017 01:15:27 +0100	[thread overview]
Message-ID: <2907620.AlD9JGsWPK@xps> (raw)
In-Reply-To: <1509713243-28460-1-git-send-email-xiaoyun.li@intel.com>

03/11/2017 13:47, Xiaoyun Li:
> This patch reverts the patchset run-time Linking support including the
> following 3 commits:
> commit 84cc318424d4 ("eal/x86: select optimized memcpy at run-time")
> commit c7fbc80fe60f ("test: select memcpy alignment unit at run-time")
> commit 5f180ae32962 ("efd: move AVX2 lookup in its own compilation unit")
> 
> The patchset would cause perf drop in vhost/virtio loopback performance
> test. Because the run-time dispatch must cost at least a function call
> comparing to the compile-time dispatch. And the reference cpu cycles value
> is small. And in the test, when using 128-256 bytes packet, it would cause
> 16%-20% perf drop with mergeble path. When using 256 bytes packet, it would
> cause 13% perf drop with vector path.
> So revert that patchset.
> 
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>

Revert applied

      reply	other threads:[~2017-11-07  0:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 12:47 Xiaoyun Li
2017-11-07  0:15 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2907620.AlD9JGsWPK@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=ophirmu@mellanox.com \
    --cc=wenzhuo.lu@intel.com \
    --cc=xiaoyun.li@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).