From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 933571B2A1 for ; Tue, 7 Nov 2017 01:15:29 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C61CA20B60; Mon, 6 Nov 2017 19:15:28 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 06 Nov 2017 19:15:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=f0MJkCYotVzoe45OdRdmozUyjS cm7ObnmzJF1QwtH/Q=; b=FOBmDyrW14gJPmfdjl49pepUYQiHUtjFwCC7yjV9PU T1WqQWZp/ePUwXybXZtsbtJ3WebatS+Q2aXdjP3EwBax3yCgIJsaBhDppFNTS2xf 1wrveNp6058FVSmdPxaOVtBwkqfoQ3XPc5lWBejhDQQQHiphUVft2eD4D+QmgySd E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=f0MJkC YotVzoe45OdRdmozUyjScm7ObnmzJF1QwtH/Q=; b=rw4LdeOlBG5SnWH7nEHJ+x iEpQM92ZuiHs9mLZFdp1vTvofKIbkTXpbLXNYsx+ySZnmAktwo4DS0zuPlE6wQQz hqnNysYCPgmPAhDWBhwrWu3eKnr+TYDjAgor2qMfOgQkt8RcyvW1fGcRnuYTInvJ daNXOTg2K1ysUHmuJRE3wLofnE2UzSiZkwyR1ihUk/k/VL0Cma+5EqZEP7VKir9E 8i+v+gRCyXfsMwad2wRWEjdIUTSh3qzD9+RJjIRbVF2H4d5ckZMiybpMBT5WQba7 0jSlp7h7Ao6cKUlcoR9f1aPx51q5TWX/tah8Lbpw9T/YgVGZReG0cs2Af+QRak4Q == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 81D617F8F6; Mon, 6 Nov 2017 19:15:28 -0500 (EST) From: Thomas Monjalon To: Xiaoyun Li Cc: dev@dpdk.org, zhihong.wang@intel.com, konstantin.ananyev@intel.com, bruce.richardson@intel.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, ophirmu@mellanox.com Date: Tue, 07 Nov 2017 01:15:27 +0100 Message-ID: <2907620.AlD9JGsWPK@xps> In-Reply-To: <1509713243-28460-1-git-send-email-xiaoyun.li@intel.com> References: <1509713243-28460-1-git-send-email-xiaoyun.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal/x86: revert select optimized memcpy at run-time X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 00:15:29 -0000 03/11/2017 13:47, Xiaoyun Li: > This patch reverts the patchset run-time Linking support including the > following 3 commits: > commit 84cc318424d4 ("eal/x86: select optimized memcpy at run-time") > commit c7fbc80fe60f ("test: select memcpy alignment unit at run-time") > commit 5f180ae32962 ("efd: move AVX2 lookup in its own compilation unit") > > The patchset would cause perf drop in vhost/virtio loopback performance > test. Because the run-time dispatch must cost at least a function call > comparing to the compile-time dispatch. And the reference cpu cycles value > is small. And in the test, when using 128-256 bytes packet, it would cause > 16%-20% perf drop with mergeble path. When using 256 bytes packet, it would > cause 13% perf drop with vector path. > So revert that patchset. > > Signed-off-by: Xiaoyun Li Revert applied