From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5D38A42B8F;
Wed, 24 May 2023 18:05:49 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id ACEAD42D42;
Wed, 24 May 2023 18:03:26 +0200 (CEST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 85ACB42D41;
Wed, 24 May 2023 18:03:25 +0200 (CEST)
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
by mailout.nyi.internal (Postfix) with ESMTP id 085B15C0129;
Wed, 24 May 2023 12:03:25 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute6.internal (MEProxy); Wed, 24 May 2023 12:03:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to; s=fm1; t=
1684944205; x=1685030605; bh=Wr8OKpyLGFa+t7I7c840MaZbPxUMFPY5j9D
Gc9hTxwM=; b=l2F6eRKuUwhkCHDxGFqB+M0QPlFAGazYjxnFSsA2XWYffo4dvqD
YISD1cJC3gjrBbpalw1xtOdMzha7v+Ns4uz9RBbTMMoTHLoahO0rkkyDkeEO780O
ZpNZAzKIU/7lqYfBZ211SwUt3uuTilj0/uO1noaqJUuZvzf4oa0RKNUTXqUaD2su
NYse+YU+xkAgXVINqj2YRXdbk7icAhmpfA+h61lwO/8gufi0GBbpm59OBzFaHmWz
AbhYv3PT8XcPrnDCKAwgIAwnwK7A+4SDHiHOjjfsNiEHtD3O0aXv67q/mx6hXMfk
8YxxyyqD7niR7hgDZc6yTibTv95wIKCqsxA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=
1684944205; x=1685030605; bh=Wr8OKpyLGFa+t7I7c840MaZbPxUMFPY5j9D
Gc9hTxwM=; b=HEARc/Qlg730Sobp/HcANP3J0wlKc6kc+d016qGdjNhc5NrYzzb
4fNAHS1CM3+i4mODs6cF8e4Q8E06+cKPuxein73fl2rjsiixK9AQsMCwDw5aVzxf
2aO9hLq5HBMR2A0Q1S3b+nB61YkztG/MczA/EsYTHQ8kQK19/GltDvAhdCydVXac
JVpzRyomybd4R9fC+v0Wzw6S01CvWZwJl+Bcw0upYt/eA85AXDYW8GJrqYwfU3uG
68z30AqicP5h95vHKZbz1FWOkCkEiGoEhkFwVS7dDqZHn+47Yg8lfbzOBX8zFmdb
NfCyikVOr9gTSDdbamsiTzzU9JivZpbj8lA==
X-ME-Sender: <xms:TDVuZBeBqK9ikgeGGTFfJrkdM_qOtpu_QJhi45EpQY9OJoEzVX00aA>
<xme:TDVuZPO842mnWfC2SKQU0r1S3_SNHR9XiD5np9aVorAF_-BCQKe91oTKxN3j9aRTV
wIHFA5z7ptGsnxulA>
X-ME-Received: <xmr:TDVuZKgdHpNr5n0P1wIf-StPHRuUCxi4XqrvgGCnTFNe7PQKnswGxR1x9IbG31xa8GTTO7I4US2ePtdN1_5qA1MxEA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejhedgleegucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpeegiefgffeuleevueetgfffgedutddutefgveevtefhudehteet
keegteehjeegleenucffohhmrghinhepfhhrvggvsghsugdrohhrghenucevlhhushhtvg
hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhj
rghlohhnrdhnvght
X-ME-Proxy: <xmx:TDVuZK_8Ov5vsXhAjDBuZoyjmmLrHxbHKXmJBogOzENhMkB9iZrYDg>
<xmx:TDVuZNuUui11oPLcrFQtU282_rFGWVn9CzJhAqcqch6k_R-7YQFEQQ>
<xmx:TDVuZJG_-L7ckgzLQVU4sJkBFcQugLXX_kn8x0a6gSd4b_WwpxuPWA>
<xmx:TTVuZFImqcECW7MT3p2w9sexjLNRkfWC5Y3Xaxq1xxnjZpXIpfWnKA>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
24 May 2023 12:03:23 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, John Baldwin <jhb@freebsd.org>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH] freebsd/contigmem: fix function parameter list
Date: Wed, 24 May 2023 18:03:22 +0200
Message-ID: <2907661.o0KrE1Onz3@thomas>
In-Reply-To: <20230522160203.GA24885@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20230522092241.20773-1-bruce.richardson@intel.com>
<20230522160203.GA24885@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
22/05/2023 18:02, Tyler Retzlaff:
> On Mon, May 22, 2023 at 10:22:41AM +0100, Bruce Richardson wrote:
> > Functions which take no parameters should explicitly have "(void)" as
> > the parameter list, rather than "()".
> >
> > Reported upstream on FreeBSD ports collection [1].
> >
> > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271524
> >
> > Fixes: 764bf26873b9 ("add FreeBSD support")
> > Cc: stable@dpdk.org
> >
> > Reported-by: John Baldwin <jhb@FreeBSD.org>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.