From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 83DEF42B91;
Wed, 24 May 2023 23:16:19 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 120904067E;
Wed, 24 May 2023 23:16:19 +0200 (CEST)
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
[64.147.123.24])
by mails.dpdk.org (Postfix) with ESMTP id 0915B40156;
Wed, 24 May 2023 23:16:18 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.west.internal (Postfix) with ESMTP id B0FF73200B2A;
Wed, 24 May 2023 17:16:16 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute4.internal (MEProxy); Wed, 24 May 2023 17:16:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to; s=fm1; t=
1684962976; x=1685049376; bh=CbrJS5KsNT/FIilebwqncg9m0l2ua9V0XlM
ubVYhhbI=; b=GarSInAhRMHfQhZdVxxZ6c0vKAEpRc+DIY00SY+jUBf0P6PO0hl
SvzIpsQCN/VBG172ENBxY/dLrmWk+oxWd00lEEbjjscQYid15ZdZVIqyWE3TKo3q
7GFVaPgnMpRwBUKQV0tGXf0k5InCq4Fwh/DS8ZXouLCQufX16cx+1cA/km1Yib52
lZzLiFbFsOFu0uVyrvjtkL/RESzfX9MvMsVRVqlksmY9DqJUXNUE+uX17D9I6RMO
Q5W8kUI2KmWu5KzaMTEOW33l4XIegTV5vFqlhG79zwE/0iNL8JPaQOvp5IbF3O9e
u/d7jahqbMF5PhPJTi4GEfymb4n/AQ9LOyw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=
1684962976; x=1685049376; bh=CbrJS5KsNT/FIilebwqncg9m0l2ua9V0XlM
ubVYhhbI=; b=fF0lnGVYWuF3Iq758jddMsPKyfEmauFZDlsjbvJvyLduSEP0T5/
VQJBnDIYo+gsXIKE9hDp4vX2Sa/QsGYykGNMjdIl2rAsutlj0yBnLhrp07j8rRO2
TV+x74JfDuvY+l8RruufBwgKHRtMw7Ez23op7h33cTJEFOgYZ4yggGQsE6C+u1Is
xm3+Gg7qh6nfcgOX5AlJpMaTRcK1GlyexHYAS8lJEWJyArH0Wc07USlRMub6++RS
k1DKVbLyOZTnv9u88nOq0/3fkQHUtqFHJfN/JQupKczgfOBaNTseoOjFTj94PuuT
GXZ/63gFwusB8LzL6d8lxrWkIAlFXRkVDAA==
X-ME-Sender: <xms:oH5uZPBHgfb7Qq4vaNa0fbfWbA_IA8TeSfpf4RhfJBtelZSwePgSHA>
<xme:oH5uZFhd49SIzSNhzkyeWAYVdPFNNQO6HQnp_N-3n_TcRWawQMyM76HhMI1_vC5_Z
zqSDPTPnbebfXRhfA>
X-ME-Received: <xmr:oH5uZKkmLD_k1n9ukPEu73LNffCeMwToR__Tx6qa-Fn7RnAazMpaD8b5S3ZBgGSr6mHz74Wj_cTXCGH7WPrVLbmIVw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejhedgudehjecutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho
mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne
cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt
ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh
hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:oH5uZBy4NweExO-jBbK9yOq-wq2yw07lmZKA7oVcD3Jd-9mvLE21Jw>
<xmx:oH5uZERQNmDkPiM78qLB78E8ESMWzQgboWTgDlsAkB-4QvY5bKsXMg>
<xmx:oH5uZEbh0zqyqpepKsJOQ9N4UNlz1FtfgoM8YSQZeZN8_E025BSR8Q>
<xmx:oH5uZKfpAB0VUponYxEn1YlBMOHSX0Y3KeQ1ekqiAOOZlZTTeecbog>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
24 May 2023 17:16:15 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Kamalakannan R <kamalakannan.r@intel.com>
Cc: dev@dpdk.org, harshad.suresh.narayane@intel.com, stable@dpdk.org,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH v3] pipeline: fix double free error for table stats
Date: Wed, 24 May 2023 23:16:13 +0200
Message-ID: <2907693.2VHbPRQshP@thomas>
In-Reply-To: <20230417112243.727023-1-kamalakannan.r@intel.com>
References: <20230417112243.727023-1-kamalakannan.r@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
17/04/2023 13:22, Kamalakannan R:
> The pointer to the table statistics data structure needs to be set
> to NULL after free inside the table_build_free(), as this function is
> called from multiple places, leading to double memory free error.
>
> Similar fix for the learner_build_free() function.
>
> Fixes: 742b0a57f50 ("pipeline: add table statistics to SWX")
> Fixes: 4f59d372614 ("pipeline: support learner tables")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kamalakannan R <kamalakannan.r@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks.