From: Eelco Chaudron <echaudro@redhat.com>
To: Fan Zhang <roy.fan.zhang@intel.com>, dev@dpdk.org
Cc: michael.j.glynn@intel.com, stable@dpdk.org,
helin.zhang@intel.com, cunming.liang@intel.com,
Andrey Chilikin <andrey.chilikin@intel.com>,
Flavio Leitner <fbl@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] drivers/i40e: fix link update no wait
Date: Thu, 8 Mar 2018 14:01:57 +0100 [thread overview]
Message-ID: <290d9547-7a9c-e280-e8ce-27b96442fdf2@redhat.com> (raw)
In-Reply-To: <20180308121752.70424-1-roy.fan.zhang@intel.com>
On 08/03/18 13:17, Fan Zhang wrote:
> Fixes: 263333bbb7a9 ("i40e: fix link status timeout")
> Cc: cunming.liang@intel.com
> Cc: stable@dpdk.org
>
> In i40e_dev_link_update() the driver obtains the link status
> info via admin queue command despite of "no_wait" flag. This
> requires relatively long time and may be a problem to some
> application such as ovs-dpdk
> (https://bugzilla.redhat.com/show_bug.cgi?id=1551761).
>
> This patch aims to fix the problem by using a different
> approach of obtaining link status for i40e NIC without waiting.
> Instead of getting the link status via admin queue command,
> this patch reads the link status registers to accelerate the
> procedure.
Reviewed the changes, and tested them in combination with Open vSwitch
bonds/direct interfaces through various VMs and found no problems. Also
tested basic link flapping.
Reviewed-by: Eelco Chaudron <echaudro@redhat.com>
Tested-by: Eelco Chaudron <echaudro@redhat.com>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> Signed-off-by: Andrey Chilikin <andrey.chilikin@intel.com>
> ---
> v2:
> - add ccs after fixline
>
> <SNIP>
next prev parent reply other threads:[~2018-03-08 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 11:55 [dpdk-dev] [PATCH] " Fan Zhang
2018-03-08 12:17 ` [dpdk-dev] [PATCH v2] " Fan Zhang
2018-03-08 13:01 ` Eelco Chaudron [this message]
2018-03-09 8:45 ` Lu, Wenzhuo
2018-03-09 13:22 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=290d9547-7a9c-e280-e8ce-27b96442fdf2@redhat.com \
--to=echaudro@redhat.com \
--cc=andrey.chilikin@intel.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=fbl@redhat.com \
--cc=helin.zhang@intel.com \
--cc=michael.j.glynn@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).