From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <echaudro@redhat.com>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 11A995F13;
 Thu,  8 Mar 2018 14:01:59 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
 [10.11.54.4])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 33CF44023BB3;
 Thu,  8 Mar 2018 13:01:59 +0000 (UTC)
Received: from rhvm.imac (ovpn-116-134.ams2.redhat.com [10.36.116.134])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 0F8212023227;
 Thu,  8 Mar 2018 13:01:57 +0000 (UTC)
To: Fan Zhang <roy.fan.zhang@intel.com>, dev@dpdk.org
Cc: michael.j.glynn@intel.com, stable@dpdk.org, helin.zhang@intel.com,
 cunming.liang@intel.com, Andrey Chilikin <andrey.chilikin@intel.com>,
 Flavio Leitner <fbl@redhat.com>
References: <20180308115524.70244-1-roy.fan.zhang@intel.com>
 <20180308121752.70424-1-roy.fan.zhang@intel.com>
From: Eelco Chaudron <echaudro@redhat.com>
Organization: Red Hat
Message-ID: <290d9547-7a9c-e280-e8ce-27b96442fdf2@redhat.com>
Date: Thu, 8 Mar 2018 14:01:57 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180308121752.70424-1-roy.fan.zhang@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.7]); Thu, 08 Mar 2018 13:01:59 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]);
 Thu, 08 Mar 2018 13:01:59 +0000 (UTC) for IP:'10.11.54.4'
 DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'echaudro@redhat.com' RCPT:''
Subject: Re: [dpdk-dev] [PATCH v2] drivers/i40e: fix link update no wait
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: echaudro@redhat.com
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Mar 2018 13:02:00 -0000

On 08/03/18 13:17, Fan Zhang wrote:
> Fixes: 263333bbb7a9 ("i40e: fix link status timeout")
> Cc: cunming.liang@intel.com
> Cc: stable@dpdk.org
>
> In i40e_dev_link_update() the driver obtains the link status
> info via admin queue command despite of "no_wait" flag. This
> requires relatively long time and may be a problem to some
> application such as ovs-dpdk
> (https://bugzilla.redhat.com/show_bug.cgi?id=1551761).
>
> This patch aims to fix the problem by using a different
> approach of obtaining link status for i40e NIC without waiting.
> Instead of getting the link status via admin queue command,
> this patch reads the link status registers to accelerate the
> procedure.
Reviewed the changes, and tested them in combination with Open vSwitch 
bonds/direct interfaces through various VMs and found no problems. Also 
tested basic link flapping.

Reviewed-by: Eelco Chaudron <echaudro@redhat.com>
Tested-by: Eelco Chaudron <echaudro@redhat.com>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> Signed-off-by: Andrey Chilikin <andrey.chilikin@intel.com>
> ---
> v2:
> - add ccs after fixline
>
> <SNIP>