From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
 [74.125.82.177]) by dpdk.org (Postfix) with ESMTP id EB8F530D
 for <dev@dpdk.org>; Tue, 17 Jun 2014 11:58:08 +0200 (CEST)
Received: by mail-we0-f177.google.com with SMTP id u56so6669678wes.8
 for <dev@dpdk.org>; Tue, 17 Jun 2014 02:58:25 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=6omgyRxWyFAlhFKDCHOXP4iAK+XmZ4eEtQsGJAz0ahc=;
 b=GAtFYw9/vZ4jup1hh3snIgdaTeUr7KvBQTTJYReHbewad36GzovbRP0GrsjcyGca/n
 +WbV39eVhBtoVem6YjtqAX0PBOCAYnPwgDtgsnFxlzFGeARBnIjDZEWHd3/r9HlxPbjh
 Xa+qtg8kLLqZFtvXFYJRq9PMycsoaO1N5gtY+Q3UxYu5UQB/xZ9urdiV41uk9UIjcEGg
 BuLVP5Gg5rdA7k0aOTRtYcL1aJuRxK7e0uXEJL0pC3hgLihJeD64Sr+jJeMI2i9ifr6S
 urKbN3hGWT24gKMfYOWqK/ZatfPTdkfTfdXn4xmJp3+DDG4YM85FBlRUdn0qirtpV2bp
 q4bg==
X-Gm-Message-State: ALoCoQmNOlHMiCGq2v6T75cStlsK+37hXJDodNAYVNiqkINLuCrj8mWRSRDT7wkN4Ssy3bNoqfiu
X-Received: by 10.180.36.241 with SMTP id t17mr35342620wij.38.1402999105199;
 Tue, 17 Jun 2014 02:58:25 -0700 (PDT)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by mx.google.com with ESMTPSA id lo18sm19296996wic.1.2014.06.17.02.58.23
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 17 Jun 2014 02:58:24 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pablo de Lara <pablox.de.lara.guarch@intel.com>
Date: Tue, 17 Jun 2014 11:58:23 +0200
Message-ID: <2911412.mu6nWGPa7z@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; )
In-Reply-To: <1402436007-25730-1-git-send-email-pablox.de.lara.guarch@intel.com>
References: <1402412388-12580-1-git-send-email-pablox.de.lara.guarch@intel.com>
 <1402436007-25730-1-git-send-email-pablox.de.lara.guarch@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: Fix for 82599 Bypass NIC,
	getting incorrect media type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jun 2014 09:58:09 -0000

> Function ixgbe_get_media_type_82599 returns media_type =
> ixgbe_media_type_unknown, when using an 82599 Bypass NIC,
> so that causes link status interrupt not to work properly.
> 
> change in v2: Fixed compilation error when RTE_NIC_BYPASS=n
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)

Note that we shouldn't modify the Intel base driver.
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied for version 1.7.0.
Feel free to revert if someone think it's not acceptable.

-- 
Thomas