From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 103C0A09E0; Sat, 14 Nov 2020 11:01:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95E0BC88E; Sat, 14 Nov 2020 11:01:12 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 17165C882; Sat, 14 Nov 2020 11:01:10 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 7E4ADD45; Sat, 14 Nov 2020 05:01:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 14 Nov 2020 05:01:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= deKATPlooKdIoSTxxWUgEyls6mPl9DMXyyWxpiuvyHI=; b=aaWZcjOubIKv6zKl FLSwlT6fJxW+MqRi9p/Y092TUNwfpUMzYJqOsL3frXt3irqACNvb8yePi54LbH7f 6Uonf3VVlhmD69wds+CtElS8iBTwlzbBSUkFcUXQcNwCw0UY7K90XFwreJMatsBR wfc+KuQ2ufS4W0IPxtwFsALPenVx4xJWZ6r9h2fPxuufq2jCvXtHTV1whUeYTtMk /pDBu+CioGngeKzh3T5TSzYkjSHetdBrJlAYkyjE9c1ObTHEKvm5tkMQfPyx8AIz OO38iDtLzz/DZ+Lianbl4oOGoeBi+ZvEszFU56HM8SWcpjg+AdIHH7N8waIaqk/c zkb9hQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=deKATPlooKdIoSTxxWUgEyls6mPl9DMXyyWxpiuvy HI=; b=IPNB0T9Sb8VWabs5vC74HjGB6lapALx5+bKfwmGhyc24Lpxe3XwJ0vgCP JG6sHPDRBMYETZMxPSRPBJX5HDtSVMG+oeggKNMnuS3guErUWCwVft7hA+bwFI1L EHXyL3uzglkkCKG55wT5oD+E6QvPWPSe+k+PHvvZojrx3+xdwobLfGCX1Azz0BwV jwgrkz1LDDdpZnbIo/ilGv0bTRcz7DsR/cr3TYjqlOaWheiJ97Y9QiBpuAFQGy4i jwgLigCg9AcmHwGVMKkKok8XjsuPMbAnq+mgvVoMLPpDoxtAr8P3jsr5bWAackJ5 s/j1GhSspsXrTOFEAsuDeW08zONvw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddvjedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C68473280059; Sat, 14 Nov 2020 05:01:05 -0500 (EST) From: Thomas Monjalon To: Viacheslav Ovsiienko Cc: dev@dpdk.org, stable@dpdk.org, rasland@nvidia.com, matan@nvidia.com, asafp@nvidia.com, david.marchand@redhat.com Date: Sat, 14 Nov 2020 11:01:04 +0100 Message-ID: <2912116.G3pJfsNsrf@thomas> In-Reply-To: <1605024259-18318-1-git-send-email-viacheslavo@nvidia.com> References: <1605024259-18318-1-git-send-email-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/4] common/mlx5: share UAR allocation routine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/11/2020 17:04, Viacheslav Ovsiienko: > +void * > +mlx5_devx_alloc_uar(void *ctx, int mapping) > +{ > + void *uar; > + uint32_t retry, uar_mapping; > + void *base_addr; > + > + for (retry =3D 0; retry < MLX5_ALLOC_UAR_RETRY; ++retry) { > +#ifdef MLX5DV_UAR_ALLOC_TYPE_NC > + /* Control the mapping type according to the settings. */ > + uar_mapping =3D (mapping < 0) ? > + MLX5DV_UAR_ALLOC_TYPE_NC : mapping; > +#else > + /* > + * It seems we have no way to control the memory mapping type > + * for the UAR, the default "Write-Combining" type is supposed. > + */ > + uar_mapping =3D 0; > +#endif A failure was reported by the CI: error: unused parameter =E2=80=98mapping=E2=80=99 It is fixed while merging by adding the below in the #else case: RTE_SET_USED(mapping); Please take care of CI results!