From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8EED81B1F4 for ; Wed, 9 Jan 2019 10:55:13 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1F817244E1; Wed, 9 Jan 2019 04:55:13 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 09 Jan 2019 04:55:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=zF1oB/49SSVfmy8EEwNgTUbtY6r+SK4WX3VYl1j3IZY=; b=k0TrphXoq8t4 zrn0cOaQDeJsC6QrJAVf3mZDknq2FU0gnOMZDJ58T2N4emeXYDINz0+pawnY8Uhp eADiKyBDaS34zVzIh3UgJxB+YOulY8O7Klsrz5psq7G1xPkzIwv7uK53F0NuK5Og XFbVnnqLhwDvX6jCUFKZ6dRMT7NPgxY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=zF1oB/49SSVfmy8EEwNgTUbtY6r+SK4WX3VYl1j3I ZY=; b=J1XNnR6/EOKHoWNfHAq7JrwvLITMzzrllPR/rA2viFlNbfBLqfXjmdF6z K85n/PJ/oA967RWjupj+Z9Hem5gVYqN5lVTkhDz1TQ3A1MY3RDB3z+C/KlWWM9Uk 1Pc5jkqId3gSCAoAEFxLIOTQsMFnl0CP/nFuNCOllt8rS1FJvHbZwGJBGkbKRcy3 CMVhLLAgqcABqCpkx+EKkv398L2DAHSR+1sK0NqKsaUQ9LnAbLzxheafg1PwXfjP Y60n6zM6HhmHknXu2TOdTxTqx7SaCOzQogLsoVOC2C9r0BYtRAKDLjfVE41sooSu +XEVakBfLNq4PNiS2qDlDb2Kao2tg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfedugddtleculddtuddrgedtkedrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehmvghsohhnsghuihhlugdrtghomhenucfkphepjeejrddufeegrddvtdef rddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghloh hnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BD169100B8; Wed, 9 Jan 2019 04:55:11 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: yskoh@mellanox.com, shahafs@mellanox.com, dev@dpdk.org, ferruh.yigit@intel.com Date: Wed, 09 Jan 2019 10:55:10 +0100 Message-ID: <2914354.2em5lQ1s6L@xps> In-Reply-To: <20190109093345.GA2940@bricha3-MOBL.ger.corp.intel.com> References: <20190109020524.3633-1-thomas@monjalon.net> <20190109093345.GA2940@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] config: gather options for dlopen mlx dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 09:55:13 -0000 09/01/2019 10:33, Bruce Richardson: > On Wed, Jan 09, 2019 at 03:05:23AM +0100, Thomas Monjalon wrote: > > Rename options CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS and > > CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS to a single option > > CONFIG_RTE_IBVERBS_LINK_DLOPEN. > > Rename meson option enable_driver_mlx_glue to ibverbs_link. > > > > There was no good reason for setting a different link option > > for mlx4 and mlx5. Having a single common option makes it > > easier to understand and unify make and meson systems. [...] > > --- a/meson_options.txt > > +++ b/meson_options.txt > > @@ -2,8 +2,8 @@ option('allow_invalid_socket_id', type: 'boolean', value: false, > > description: 'allow out-of-range NUMA socket id\'s for platforms that don\'t report the value correctly') > > option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-', > > description: 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.') > > -option('enable_driver_mlx_glue', type: 'boolean', value: false, > > - description: 'Enable glue library for Mellanox PMDs') > > +option('ibverbs_link', type: 'string', value: 'shared', > > + description: 'Linkage method (shared/dlopen) for Mellanox PMDs with ibverbs dependencies.') > > I think it's better to use the "combo" option type here rather than > a generic string. That way we get proper protection against typos when > configuring. > [Ref: https://mesonbuild.com/Build-options.html] Good suggestion, I did not check such option exists. I will send a v2.