From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 9B5F35699 for ; Tue, 19 Feb 2019 12:40:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2019 03:40:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,388,1544515200"; d="scan'208";a="300851868" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.110]) ([10.237.220.110]) by orsmga005.jf.intel.com with ESMTP; 19 Feb 2019 03:40:20 -0800 To: David Marchand Cc: dev@dpdk.org References: <1550150874-9535-1-git-send-email-david.marchand@redhat.com> <1fed1442-efc2-0156-7db1-8b2c01292659@intel.com> From: "Burakov, Anatoly" Message-ID: <29172348-cc0c-1b36-cefc-6b3ef92137f1@intel.com> Date: Tue, 19 Feb 2019 11:40:19 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] eal: fix check when retrieving current cpu affinity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Feb 2019 11:40:38 -0000 On 14-Feb-19 5:41 PM, David Marchand wrote: > > > On Thu, Feb 14, 2019 at 5:44 PM Burakov, Anatoly > > wrote: > > On 14-Feb-19 1:27 PM, David Marchand wrote: > > pthread_getaffinity_np returns a >0 value when failing. > > > > This is mainly for the sake of correctness. > > The only case where it could fail is when passing an incorrect cpuset > > size wrt to the kernel. > > > > Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") > > Signed-off-by: David Marchand > > > --- > >   lib/librte_eal/common/eal_common_options.c | 5 ++--- > >   1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/lib/librte_eal/common/eal_common_options.c > b/lib/librte_eal/common/eal_common_options.c > > index 6c96f45..1f45f82 100644 > > --- a/lib/librte_eal/common/eal_common_options.c > > +++ b/lib/librte_eal/common/eal_common_options.c > > @@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c) > >       unsigned int lcore_id; > >       unsigned int removed = 0; > >       rte_cpuset_t affinity_set; > > -     pthread_t tid = pthread_self(); > > > > -     if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t), > > -                             &affinity_set) < 0) > > +     if (pthread_getaffinity_np(pthread_self(), > sizeof(rte_cpuset_t), > > +                             &affinity_set)) > >               CPU_ZERO(&affinity_set); > > > >       for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { > > > CC: stable? > > > Not really sure about CCing stable for this. > > I did not get errors with pthread_getaffinity_np so far. > Afaiu, it would need the kernel and libc to have different cpuset sizes. > I did not investigate in which situations it could happen. > You're incorrectly handling error condition - that's a bug regardless of how likely it is to occur :) -- Thanks, Anatoly