DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Trahe, Fiona" <fiona.trahe@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Akhil Goyal <akhil.goyal@nxp.com>,
	"Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com>,
	"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5] compress/qat: enable dynamic huffman encoding
Date: Thu, 25 Oct 2018 08:45:17 +0200	[thread overview]
Message-ID: <2919877.NPW9lr0NG8@xps> (raw)
In-Reply-To: <348A99DA5F5B7549AA880327E580B43589657639@IRSMSX101.ger.corp.intel.com>

25/10/2018 02:40, Trahe, Fiona:
> I'll send a v6.
> On which OS/compiler did this fail to compile?

It fails on i686 of course.

I already sent some general notes in the past, explaining how %lx
is most of the time wrong. %PRIu64 is the right specifier.

https://www.mail-archive.com/dev@dpdk.org/msg90644.html

> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 24/10/2018 16:15, Akhil Goyal:
> > >
> > > On 10/18/2018 2:18 AM, Fiona Trahe wrote:
> > > > Enable dynamic huffman encoding in the QAT comp PMD.
> > > >
> > > > Signed-off-by: Tomasz Jozwiak<tomaszx.jozwiak@intel.com>
> > > > Signed-off-by: Fiona Trahe<fiona.trahe@intel.com>
> > > > Acked-by: Arek Kusztal<arkadiuszx.kusztal@intel.com>
> > > > ---
> > > Applied to dpdk-next-crypto
> > 
> > error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 7 has type ‘phys_addr_t’
> > {aka ‘long long unsigned int’} [-Werror=format=]
> >     "%s(): " fmt "\n", __func__, ## args)
> >     ^~~~~~~~
> > drivers/compress/qat/qat_comp_pmd.c:194:2: note: in expansion of macro ‘QAT_LOG’
> >   QAT_LOG(DEBUG, "Memzone %s: addr = %p, phys = %lx, size required %d,"
> > 
> > 
> > One more comment about the release notes, please try to integrate
> > compressdev features between cryptodev and eventdev.
> > 
> 
> 

  reply	other threads:[~2018-10-25  6:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 17:46 [dpdk-dev] [PATCH] " Fiona Trahe
2018-10-05 16:18 ` [dpdk-dev] [PATCH v2] " Fiona Trahe
2018-10-09 11:01   ` Akhil Goyal
2018-10-09 14:09     ` Trahe, Fiona
2018-10-12 11:39       ` Akhil Goyal
2018-10-11 17:03   ` [dpdk-dev] [PATCH v3] " Fiona Trahe
2018-10-15 23:16     ` [dpdk-dev] [PATCH v4] " Fiona Trahe
2018-10-17 10:29       ` Kusztal, ArkadiuszX
2018-10-17 20:48       ` [dpdk-dev] [PATCH v5] " Fiona Trahe
2018-10-24 14:15         ` Akhil Goyal
2018-10-24 21:30           ` Thomas Monjalon
2018-10-25  0:40             ` Trahe, Fiona
2018-10-25  6:45               ` Thomas Monjalon [this message]
2018-10-25  1:30         ` [dpdk-dev] [PATCH v6] " Fiona Trahe
2018-10-25  7:34           ` Akhil Goyal
2018-10-26 18:18           ` [dpdk-dev] [PATCH v7] " Fiona Trahe
2018-10-27  0:06             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2919877.NPW9lr0NG8@xps \
    --to=thomas@monjalon.net \
    --cc=akhil.goyal@nxp.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=tomaszx.jozwiak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).