Re: [dpdk-dev] [PATCH 1/3] net/szedata2: do not affect Ethernet interfaces

[Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>]

On 2018/04/12 16:38, Matej Vido wrote:
> On 11.04.2018 12:51, Ferruh Yigit wrote:
>> On 4/11/2018 10:36 AM, Matej Vido wrote:
>>> On 10.04.2018 17:28, Ferruh Yigit wrote:
>>>> On 4/6/2018 3:12 PM, Matej Vido wrote:
>>>>> NFB cards employ multiple Ethernet ports.
>>>>> Until now, Ethernet port-related operations were performed on all 
>>>>> of them
>>>>> (since the whole card was represented as a single port).
>>>>> With new NFB-200G2QL card, this is no longer viable.
>>>>>
>>>>> Since there is no fixed mapping between the queues and Ethernet ports,
>>>>> and since a single card can be represented as two ports in DPDK,
>>>>> there is no way of telling which (if any) physical ports should be
>>>>> associated with individual ports in DPDK.
>>>>>
>>>>> This is also described in documentation in more detail.
>>>>>
>>>>> Signed-off-by: Matej Vido <vido@cesnet.cz>
>>>>> Signed-off-by: Jan Remes <remes@netcope.com>
>>>>> ---
>>>>>    config/common_base                                 |   5 -
>>>>>    .../nics/img/szedata2_nfb200g_architecture.svg     | 171 
>>>>> +++++++++++
>>>> Hi Matej,
>>>>
>>>> This patch fails to apply [1], can you please confirm you can apply it?
>>>>
>>>> [1]
>>>> $ git apply --check
>>>> dpdk-dev-1-3-net-szedata2-do-not-affect-Ethernet-interfaces.patch
>>>> error: corrupt patch at line 270
>>> Hi Ferruh,
>>>
>>> I've got same error on patch downloaded from patchwork. It seems that
>>> the difference between the downloaded patch and the patch generated from
>>> git is that the long lines in svg file are split into multiple lines in
>>> the patch downloaded from patchwork. I suppose this could be the
>>> problem. Any idea how to send a patch containing svg file correctly?
>> cc'ed Ogawa-san for support,
>>
>> I remember he fixed similar issue in the past for spp, but I don't 
>> remember how?
> Anyways I've hopefully fixed this by redrawing the image to avoid those 
> long lines. I'm sending v2.
> 
> Thanks,
> Matej
Hi Matej, Ferruh,

I also encountered the same problem for 998 chars limitation of SMTP. I 
fixed it by replacing objects with simpler ones.

You can check this error by using '--validate' option of git send-email.

Thanks,
Yasufumi
>>
>>> Thanks,
>>> Matej
>>>
> 
> 
> 


-- 
Yasufumi Ogawa
NTT Network Service Systems Labs