From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7F02E1B1FB for ; Wed, 26 Sep 2018 19:20:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 10:20:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,307,1534834800"; d="scan'208";a="260453420" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by orsmga005.jf.intel.com with ESMTP; 26 Sep 2018 10:20:26 -0700 To: Stephen Hemminger , dev@dpdk.org Cc: Stephen Hemminger References: <20180914153019.8983-1-stephen@networkplumber.org> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <2919e34a-f943-80fc-d2f0-d1c53fde0cae@intel.com> Date: Wed, 26 Sep 2018 18:20:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180914153019.8983-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix refcount if open returns error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 17:20:30 -0000 On 9/14/2018 4:30 PM, Stephen Hemminger wrote: > This fixes the problem of reference count leak if > igbuio_pci_enable_interrupts fails. > > Also, replace mutex and integer with a kernel atomic counter. > This is standard pattern for kernel devices. > > Fixes: 19685d5aa79c ("igb_uio: allow multi-process access") > Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit