From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39D60A10DA for ; Wed, 31 Jul 2019 14:08:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0DC421C135; Wed, 31 Jul 2019 14:08:32 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id B5D7B1C12F for ; Wed, 31 Jul 2019 14:08:30 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 4B01848008E; Wed, 31 Jul 2019 12:08:29 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.152) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 31 Jul 2019 13:08:23 +0100 To: simei , , , CC: References: <1564030646-73951-1-git-send-email-simei.su@intel.com> <1564030646-73951-2-git-send-email-simei.su@intel.com> From: Andrew Rybchenko Message-ID: <291f410f-fc71-191b-8595-4c3d9e970041@solarflare.com> Date: Wed, 31 Jul 2019 15:08:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1564030646-73951-2-git-send-email-simei.su@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [85.187.13.152] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24812.003 X-TM-AS-Result: No-11.372700-8.000000-10 X-TMASE-MatchedRID: 9zTThWtzImvmLzc6AOD8DfHkpkyUphL90Y5wB8cprq4jRiu1AuxJTF1o 7wPE6VhYoL5foeeuL5iXFT8WJtp/J8WKJ8at6hW2dhnFihmbnwUO9z+P2gwiBUkrZ4mFjTbDuZe FP3ootb1s3T688YnBitouhd4Dfo6L/O8Dm420Ns8/ApMPW/xhXkyQ5fRSh265eUMkPpZu/kCjxY yRBa/qJQPTK4qtAgwIAYt5KiTiutkLbigRnpKlKSPzRlrdFGDwO5QNk34sQdJPhH6xxyp8CLsPD 0elRDbChhX/ALXrkSrgCjf9ovNLsw== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.372700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24812.003 X-MDID: 1564574910-P75q7qSrPXBk Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/25/19 7:57 AM, simei wrote: > From: Simei Su > > Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash funtion. > To support symmetric hash by rte_flow RSS action, this patch adds > new hash function "Symmetric Toeplitz" which is supported by some hardware. Isn't it a question of key to achieve symmetry? I.e. hash algorithm (function) is still the same - Toeplitz, but hash key makes the result symmetric (i.e. equal for flows in both directions - swap transport ports and IPv4/6 addresses). > Signed-off-by: Simei Su > --- > lib/librte_ethdev/rte_flow.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index f3a8fb1..2a0e6d5 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -1744,6 +1744,7 @@ enum rte_eth_hash_function { > RTE_ETH_HASH_FUNCTION_DEFAULT = 0, > RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */ > RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */ > + RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ, /**< Symmetric Toeplitz */ > RTE_ETH_HASH_FUNCTION_MAX, > }; > >