From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E81EA0C41; Tue, 19 Oct 2021 16:57:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C173C4119E; Tue, 19 Oct 2021 16:57:30 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 61BA14119D for ; Tue, 19 Oct 2021 16:57:29 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id DF0EE5C02F6; Tue, 19 Oct 2021 10:57:28 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute2.internal (MEProxy); Tue, 19 Oct 2021 10:57:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u256.net; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=lzhPqrK4jJKFVCuXxFB1pdfweFmS0oI F+JrsaM4OG+Y=; b=JNjW/BU+aXcT9jFKSVZKqsK2A3ysl2iC7By35stK75dWF6+ VHhETlk6jT6Yqb51gsz9x6bmstcSe+uesequnyCmglcT4ArQCdx3FVIVXUtjeZP3 XIDm93UjkLVcYcgPZIoD5Whvb4hUeUOJlhAhT3hsxoNeQZQh1ILWpUuFVgJIwfUO M6CvX5PLx39BVjtFYC6Txf9dgxei12Me/zVV15fAp+RQvCCxALM0eBYTaCkRdb22 ZpcQiu2HIOXDhEL+WX0AQZ+aDrgJnWNrTdmIvxlp+8SokMBSZX2wGF3wUjWIhz7P F4G5P9BDAnlfgxv3UtNwaJB7DeHrrGltIMG4h7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=lzhPqr K4jJKFVCuXxFB1pdfweFmS0oIF+JrsaM4OG+Y=; b=kFAXJzba20qss5KJwBlDFm d0sBEl586mIKpJ4XkFS/G0jJS/KBKykj2HEVlQm3xT0PTSQ7oOZ6i6lmfalSmOLe HRh0pWbTiRrJD2vZzZFIwPbPsDE56TZfqhNxbcJra0EjxyJ19sPwYHGenwU6trod QQl8DyjZt71J0FGHc12WXEW2CA78xplbJW/+bnB7VGgr4RDfVF8zZjjs9mnORJxG No3KvLeVfKvOpDyzmi0RQh4BuaUutm9RNcHvYj3pc5d8RHRknY/qP/SSTQM0vxSk 8wJzyPCWk3+E0RbYjSEHC17pHRHq/G460TgBIeQSnDqijL2neL981eOtjofpn1pw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvvddgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepifgrtoht rghnpgftihhvvghtuceoghhrihhvvgesuhdvheeirdhnvghtqeenucggtffrrghtthgvrh hnpefguefhffelleduueehueetueefgedtieevudduhfegveetuedtleeuffeuheekfeen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhhivh gvsehuvdehiedrnhgvth X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id E5E2021E006E; Tue, 19 Oct 2021 10:57:27 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-1369-gd055fb5e7c-fm-20211018.002-gd055fb5e Mime-Version: 1.0 Message-Id: <29230bc6-290d-482b-a25a-58ed07bbfa45@www.fastmail.com> In-Reply-To: <20211005155435.279043-2-xuemingl@nvidia.com> References: <20211005123012.264727-1-xuemingl@nvidia.com> <20211005155435.279043-1-xuemingl@nvidia.com> <20211005155435.279043-2-xuemingl@nvidia.com> Date: Tue, 19 Oct 2021 16:57:07 +0200 From: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= To: "Xueming(Steven) Li" , dev@dpdk.org Cc: "Thomas Monjalon" , "David Marchand" Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH v1 1/3] devargs: support path value for global device arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Steven, On Tue, Oct 5, 2021, at 17:54, Xueming Li wrote: > Slash is used to split global device arguments. > > To support path value which contains slash, this patch parses devargs by > locating both slash and layer name key: > bus=a,name=/some/path/class=b,k1=v1/driver=c,k2=v2 > "/class=" and "/driver" are valid start of a layer. > > Signed-off-by: Xueming Li The code looks good to me, and after executing with the test suite it seems to behave properly. Reviewed-by: Gaetan Rivet -- Gaetan Rivet