From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 884181077 for ; Tue, 14 Feb 2017 18:14:29 +0100 (CET) Received: by mail-wr0-f169.google.com with SMTP id c4so16776859wrd.2 for ; Tue, 14 Feb 2017 09:14:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=75lcT0lJGJmZqPwxuldMOJLTvfTEEwkHKavgySyHiT8=; b=jHviK1OjOX1uWiCvXyGOArfkpgytGloCwdXiHJ0jVbGdP1l+2/gwuvUXEVHa15hEV4 Ce+9TVo+zc5jbJ8dPocr3bYyE657EY+m9MVggEEIPK1PGOQkHjIPTSeogkmjW8WBnWNi +H/f2gyz3w1oWerwyMn4DMOZXbeUgWYOvuYmcaZOj1YFeGz/DWmX40MKlIu/8pESc6rM e1Sy7VDm9ZVrO9JUYC1K6lduy8G60+DJkv6LfYqVIL5qjzbjE+0mrcQ4dLV2HhYgAejh SfXOu8hS3sXgvwqPWi9SEE5ksnuMyUS38XrI6JC7CQLnJdxN7hoQYH6nvwbvb0jH+j03 T2EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=75lcT0lJGJmZqPwxuldMOJLTvfTEEwkHKavgySyHiT8=; b=MX5HF3uqKgW0ZnsRTqa6D4tEE+cuT4CiGWP76HIyy4goZtC7uTbxu6dMjE6punmRE/ lgFqN75lRK4ekdXcecYvXtRQhw9Egi9ViJrwQzFxu6gdNVNgmkiXD4kCldjiwB6Jr1Ns Xhaz3gFyhMJu6bqy5FRwZ8xMYBruLw4F6jNi9BeyFuVt62760Mr4CmaLQftbunvQj8nk Tl5WyNnlyISGEBMT3d6W6mkh/4ut0n/o0UQ5NWL9Et9coPstlz5FyMochfdIkzg1iLVS pBC+N6BkqzSKaK+YMTZYwUg1YKrlvGq5PwPSih35gvFEuH28n2gKseUH0ttnXXjZ3Jqb u/Ug== X-Gm-Message-State: AMke39lFkbchq4tWKAguJ5jobQWCshANuf4h/63NxnPAplD2T/2lX5pQ7LJ4Eyb6k5kdGF2i X-Received: by 10.223.142.49 with SMTP id n46mr3465552wrb.11.1487092469292; Tue, 14 Feb 2017 09:14:29 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id h75sm1533782wrh.37.2017.02.14.09.14.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Feb 2017 09:14:28 -0800 (PST) From: Thomas Monjalon To: Dmitriy Yakovlev Cc: dev@dpdk.org, "Dumitrescu, Cristian" Date: Tue, 14 Feb 2017 18:14:27 +0100 Message-ID: <2924499.9xLPenM5g3@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891265274CEFD@IRSMSX108.ger.corp.intel.com> References: <1486435866-30562-1-git-send-email-bombermag@gmail.com> <3EB4FA525960D640B5BDFFD6A3D891265274CEFD@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] cfgfile: fix uninitialized variable on load error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2017 17:14:29 -0000 > > Uninitialized scalar variable. Using uninitialized value cfg- > > >sections[curr_section]->num_entries when calling rte_cfgfile_close. > > And memory in variables cfg->sections[curr_section], sect- > > >entries[curr_entry] maybe not equal NULL. We must decrement counters > > curr_section, curr_entry when failed to realloc. > > > > Fixes: eaafbad419bf ("cfgfile: library to interpret config files") > > > > Signed-off-by: Dmitriy Yakovlev > > --- > > lib/librte_cfgfile/rte_cfgfile.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > Acked-by: Cristian Dumitrescu Applied, thanks