From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 04CE42BFA for ; Tue, 2 Oct 2018 13:53:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2018 04:53:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,331,1534834800"; d="scan'208";a="267725977" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by fmsmga005.fm.intel.com with ESMTP; 02 Oct 2018 04:53:22 -0700 To: Andrzej Ostruszka , dev@dpdk.org Cc: mw@semihalf.com, nadavh@marvell.com, zr@semihalf.com, tdu@semihalf.com References: <1537434339-22570-1-git-send-email-amo@semihalf.com> <1538385970-21260-1-git-send-email-andrzej.ostruszka@gmail.com> <1538385970-21260-2-git-send-email-andrzej.ostruszka@gmail.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <2926d9a9-bb95-f3bc-051b-c6891996b22f@intel.com> Date: Tue, 2 Oct 2018 12:53:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1538385970-21260-2-git-send-email-andrzej.ostruszka@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 1/8] net/mvneta: add neta PMD skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 11:53:23 -0000 On 10/1/2018 10:26 AM, Andrzej Ostruszka wrote: > From: Zyta Szpak > > Add neta pmd driver skeleton providing base for the further > development. > > Signed-off-by: Natalie Samsonov > Signed-off-by: Yelena Krivosheev > Signed-off-by: Dmitri Epshtein > Signed-off-by: Zyta Szpak > Signed-off-by: Andrzej Ostruszka > --- > MAINTAINERS | 8 + > config/common_base | 5 + > devtools/test-build.sh | 2 + > doc/guides/nics/features/mvneta.ini | 11 + > doc/guides/nics/mvneta.rst | 152 +++++++ dpdk/doc/guides/nics/mvneta.rst: WARNING: document isn't included in any toctree Please add document to doc/guides/nics/index.rst <...> > +Config File Options > +------------------- > + > +The following options can be modified in the ``config`` file. > + > +- ``CONFIG_RTE_LIBRTE_MVNETA_PMD`` (default ``n``) > + > + Toggle compilation of the librte_pmd_mvneta driver. > + Good to have another section to document "Runtime options" (iface) > + > +Usage example > +^^^^^^^^^^^^^ > + > +.. code-block:: console > + > + ./testpmd --vdev=net_mvneta,iface=eth0,iface=eth1 \ > + -c 3 -- -i --p 3 -a > + > + > +Building DPDK > +------------- > + > +Driver needs precompiled MUSDK library during compilation. > + > +.. code-block:: console > + > + export CROSS_COMPILE=/bin/aarch64-linux-gnu- > + ./bootstrap > + ./configure --host=aarch64-linux-gnu --enable-bpool-dma=64 getting "configure: WARNING: unrecognized options: --enable-bpool-dma" Is this config option still valid for 18.09? <...> > + > +static int mvneta_dev_num; > +static int mvneta_lcore_first; > +static int mvneta_lcore_last; These static variables seems assigned but not used, can you please check? <...> > + > +RTE_PMD_REGISTER_VDEV(net_mvneta, pmd_mvneta_drv); Need to document supported devargs with RTE_PMD_REGISTER_PARAM_STRING <...> > +struct mvneta_priv { > + /* Hot fields, used in fast path. */ > + struct neta_ppio *ppio; /**< Port handler pointer */ > + > + uint8_t pp_id; > + uint8_t ppio_id; /* ppio port id */ > + uint8_t uc_mc_flushed; > + uint8_t multiseg; > + > + struct neta_ppio_params ppio_params; > + uint16_t nb_rx_queues; Do you need this private variable, isn't it duplicate of "dev->data->nb_rx_queues"? And as far as I can see "dev->data->nb_rx_queues" one used.