From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 721C41B11F
for <dev@dpdk.org>; Wed, 10 Apr 2019 23:19:46 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 0188421305;
Wed, 10 Apr 2019 17:19:46 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Wed, 10 Apr 2019 17:19:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=MGVTvUVT3InUBQ5RZLHRa/HFrfTtMrGfvn5UTyVPA/I=; b=mQCfnKtHxApY
cCbWrtHrNP6sDWpxfrMS0Yg5ZTOReAv7wyZm2DWPwJF/6W1tfRah437NxkhQU/r1
Mt2TtAuOPIoDljXujz9LM4a5jJkbrzKW7RBL9+5GTJr/9bsGVuliMzbRQM3MHRNz
Gi1zeWqwOQKxp4KeP6AuIy3j/Hn2RHE=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=MGVTvUVT3InUBQ5RZLHRa/HFrfTtMrGfvn5UTyVPA
/I=; b=6/qq6tdfi7rIkAkJAlC8R9KbfQwK/wGUL6ZkjK1T5fzD3+FmDWz4MZby4
bW9Q+5e/sTlviJqR7dn/ybqSIGQQtbHqR4zWEAdX4rLNdgDdqyE8W6dvERklWyJn
e7tNQ9mhOPS9niwNeOV704tNUDUdAp2iwFQv9alTC20+vAtSpSPwSqLs2QE+tc5s
R/JAYjBxevhru8XBYR0iocQL8gQjP4uddum7Wq81/b/3eTYiSNuQPTm4uWwAuvWV
ZH2v5veDA9IbyycP6Ym511tFs/3VeM6/D/L6CNM88ZLPlDGCTkOLMXLDkFYTqxH3
PtMGmDYdhzXeeGxkdPGomxnXjJhlw==
X-ME-Sender: <xms:8V2uXDPWU8IQ2UK_3m6PLNzAv6wcJ2nodNqycCl-7x4agoCjhOfYgg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudejgdduiedvucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff
homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu
rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne
cuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:8V2uXI_rPhq4jmGOBPlPpTK86cV4b4LNA9hEVk1j8T33S5adNiImjA>
<xmx:8V2uXBR68fAOPY0ZrBamuaRsWaqeqgv6p2pOqIkbLM2LzyN_2t2Skw>
<xmx:8V2uXJYFAdil5lzJIGzIiFiwzc2ITAlno0nBgXJ3sND7LGhUGmwSlA>
<xmx:8V2uXM8bAjKclKWsf1CtAZQkGztrc7nvhoZRBb9Nwmh-eTQdXzxX3A>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id DD39310394;
Wed, 10 Apr 2019 17:19:44 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Date: Wed, 10 Apr 2019 23:19:43 +0200
Message-ID: <2927364.25GnhlBk6h@xps>
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E871CE0@IRSMSX108.ger.corp.intel.com>
References: <20190405120023.121419-1-jasvinder.singh@intel.com>
<20190405135441.40049-1-jasvinder.singh@intel.com>
<3EB4FA525960D640B5BDFFD6A3D891268E871CE0@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3] meter: replace color definitions with
rte_color values
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Apr 2019 21:19:46 -0000
> > This patch implements the changes proposed in the deprecation
> > note[1]. Replace multiple color definitions in various places such as
> > rte_meter.h, rte_tm.h and rte_mtr.h with single rte_color defined
> > in rte_meter.h.
> >
> > This is simple search and replace exercise without any implementation
> > change.
> >
> > [1] https://mails.dpdk.org/archives/dev/2019-January/123861.html
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
There is a compilation failure:
examples/qos_sched/cfg_file.c:67:20: error:
use of undeclared identifier 'e_RTE_METER_COLORS'
for (k = 0; k < e_RTE_METER_COLORS; k++) {
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 86BBBA0096
for <public@inbox.dpdk.org>; Wed, 10 Apr 2019 23:19:48 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 728191B274;
Wed, 10 Apr 2019 23:19:47 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 721C41B11F
for <dev@dpdk.org>; Wed, 10 Apr 2019 23:19:46 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 0188421305;
Wed, 10 Apr 2019 17:19:46 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Wed, 10 Apr 2019 17:19:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=MGVTvUVT3InUBQ5RZLHRa/HFrfTtMrGfvn5UTyVPA/I=; b=mQCfnKtHxApY
cCbWrtHrNP6sDWpxfrMS0Yg5ZTOReAv7wyZm2DWPwJF/6W1tfRah437NxkhQU/r1
Mt2TtAuOPIoDljXujz9LM4a5jJkbrzKW7RBL9+5GTJr/9bsGVuliMzbRQM3MHRNz
Gi1zeWqwOQKxp4KeP6AuIy3j/Hn2RHE=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=MGVTvUVT3InUBQ5RZLHRa/HFrfTtMrGfvn5UTyVPA
/I=; b=6/qq6tdfi7rIkAkJAlC8R9KbfQwK/wGUL6ZkjK1T5fzD3+FmDWz4MZby4
bW9Q+5e/sTlviJqR7dn/ybqSIGQQtbHqR4zWEAdX4rLNdgDdqyE8W6dvERklWyJn
e7tNQ9mhOPS9niwNeOV704tNUDUdAp2iwFQv9alTC20+vAtSpSPwSqLs2QE+tc5s
R/JAYjBxevhru8XBYR0iocQL8gQjP4uddum7Wq81/b/3eTYiSNuQPTm4uWwAuvWV
ZH2v5veDA9IbyycP6Ym511tFs/3VeM6/D/L6CNM88ZLPlDGCTkOLMXLDkFYTqxH3
PtMGmDYdhzXeeGxkdPGomxnXjJhlw==
X-ME-Sender: <xms:8V2uXDPWU8IQ2UK_3m6PLNzAv6wcJ2nodNqycCl-7x4agoCjhOfYgg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudejgdduiedvucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff
homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu
rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne
cuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:8V2uXI_rPhq4jmGOBPlPpTK86cV4b4LNA9hEVk1j8T33S5adNiImjA>
<xmx:8V2uXBR68fAOPY0ZrBamuaRsWaqeqgv6p2pOqIkbLM2LzyN_2t2Skw>
<xmx:8V2uXJYFAdil5lzJIGzIiFiwzc2ITAlno0nBgXJ3sND7LGhUGmwSlA>
<xmx:8V2uXM8bAjKclKWsf1CtAZQkGztrc7nvhoZRBb9Nwmh-eTQdXzxX3A>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id DD39310394;
Wed, 10 Apr 2019 17:19:44 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Date: Wed, 10 Apr 2019 23:19:43 +0200
Message-ID: <2927364.25GnhlBk6h@xps>
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E871CE0@IRSMSX108.ger.corp.intel.com>
References: <20190405120023.121419-1-jasvinder.singh@intel.com>
<20190405135441.40049-1-jasvinder.singh@intel.com>
<3EB4FA525960D640B5BDFFD6A3D891268E871CE0@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3] meter: replace color definitions with
rte_color values
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190410211943.OvvfTwP13gmiXy__tYXWwr5-VFv9hff6IMdRDX-uYMo@z>
> > This patch implements the changes proposed in the deprecation
> > note[1]. Replace multiple color definitions in various places such as
> > rte_meter.h, rte_tm.h and rte_mtr.h with single rte_color defined
> > in rte_meter.h.
> >
> > This is simple search and replace exercise without any implementation
> > change.
> >
> > [1] https://mails.dpdk.org/archives/dev/2019-January/123861.html
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
There is a compilation failure:
examples/qos_sched/cfg_file.c:67:20: error:
use of undeclared identifier 'e_RTE_METER_COLORS'
for (k = 0; k < e_RTE_METER_COLORS; k++) {