From: Thomas Monjalon <thomas@monjalon.net>
To: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Andrew Rybchenko <arybchenko@solarflare.com>,
dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2] net: calculate checksums for packets with IPv4 options
Date: Tue, 06 Oct 2020 17:10:27 +0200 [thread overview]
Message-ID: <2929781.z7AZqUM8vx@thomas> (raw)
In-Reply-To: <20201006081013.GE21395@platinum>
06/10/2020 10:10, Olivier Matz:
> On Mon, Oct 05, 2020 at 07:39:45PM -0700, Stephen Hemminger wrote:
> > On Tue, 06 Oct 2020 00:55:19 +0200
> > Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > On 9/1/20 12:47 PM, Michael Pfeiffer wrote:
> > > > Currently, rte_ipv4_cksum() and rte_ipv4_udptcp_cksum() assume all IPv4
> > > > headers have sizeof(struct rte_ipv4_hdr) bytes. This is not true for
> > > > those (rare) packets with IPv4 options. Thus, both IPv4 and TCP/UDP
> > > > checksums are calculated wrong.
> > > >
> > > > This patch fixes the issue by using the actual IPv4 header length from
> > > > the packet's IHL field.
> > > >
> > > > Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
> > > - doesn't it deserve a static inline function rte_ipv4_hdr_len()?
> >
> > Makes sense to have that.
>
> +1
>
> However it could be in another patch: there are ~15 places where it
> could be replaced in dpdk.
OK thanks for working on the improvement.
prev parent reply other threads:[~2020-10-06 15:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 11:32 [dpdk-dev] [PATCH] " Michael Pfeiffer
2020-08-29 11:43 ` Andrew Rybchenko
2020-09-01 9:47 ` [dpdk-dev] [PATCH v2] " Michael Pfeiffer
2020-09-07 7:48 ` Andrew Rybchenko
2020-10-05 22:55 ` Thomas Monjalon
2020-10-06 2:39 ` Stephen Hemminger
2020-10-06 8:10 ` Olivier Matz
2020-10-06 9:51 ` Michael Pfeiffer
2020-10-06 15:10 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2929781.z7AZqUM8vx@thomas \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=michael.pfeiffer@tu-ilmenau.de \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).