From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA5BDA09D3; Thu, 12 Nov 2020 14:35:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D5CE5928; Thu, 12 Nov 2020 14:35:50 +0100 (CET) Received: from out0-158.mail.aliyun.com (out0-158.mail.aliyun.com [140.205.0.158]) by dpdk.org (Postfix) with ESMTP id 2042156A3 for ; Thu, 12 Nov 2020 14:35:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alibaba-inc.com; s=default; t=1605188143; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type; bh=U2Y7KyOgNj14y/5BhKNONOmpRSbzihfzjI2HCqKUQ2E=; b=OpVTjde/mTG5b/h2r7VBBWPoR6qvRqDXs9wDx6Zqrn5L6lLM+P4PgGJhJ2CDVhNO1yY9gRdXbRGVSZOnYzT1wK/e48Ux6mYLAt2D4073T3HTHJsZeUXgYrrczCzrKIqkI79ggM69NIpZPdDDIRk/fEpUvFB27miJPOvO7l4C4ak= X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R471e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018047204; MF=huawei.xhw@alibaba-inc.com; NM=1; PH=DS; RN=9; SR=0; TI=SMTPD_---.Ivopru1_1605188141; Received: from 30.43.68.218(mailfrom:huawei.xhw@alibaba-inc.com fp:SMTPD_---.Ivopru1_1605188141) by smtp.aliyun-inc.com(127.0.0.1); Thu, 12 Nov 2020 21:35:41 +0800 To: David Marchand , Maxime Coquelin , "ferruh.yigit" Cc: "ferruh.yigit" , dev , "Burakov, Anatoly" , Zhihong Wang , "Xia, Chenbo" , Gaetan Rivet , Thomas Monjalon References: <68ecd941-9c56-4de7-fae2-2ad15bdfd81a@alibaba-inc.com> <1603381885-88819-1-git-send-email-huawei.xhw@alibaba-inc.com> <0fefe2e6-1a4d-0579-4b59-92088bfaa276@alibaba-inc.com> From: "=?UTF-8?B?6LCi5Y2O5LyfKOatpOaXtuatpOWIu++8iQ==?=" Message-ID: <292ce68b-3cd4-0de0-ed9b-4a31d5b6d12f@alibaba-inc.com> Date: Thu, 12 Nov 2020 21:35:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2020/11/10 20:42, David Marchand wrote: > On Tue, Nov 10, 2020 at 1:35 PM 谢华伟(此时此刻） wrote: >> Previously there are different ways to get port address based on >> different DPDK uio driver(IGB_UIO/UIO_PCI_GENERIC/VFIO), which is >> actually not necessary. >> >> This patch makes IO/MMIO port map/RW API more generic, which also >> supports MMIO. It also fixes performance issue with vfio. >> >> Could you spare some time to have time to review this? > This is too touchy and I don't want to mess virtio support this late > in the release. > I asked for Maxime to have a look, but he seems really busy. > > This will have to wait next release. OK.  Actually it isn't that intrusive as it looks. Then customers have to use git to clone latest DPDK when they run virtio with MMIO.  How about backporting this patch to this release after we merge it later? Maxime: Could we high prioritize this patch a bit? Customers are frequently pushing us. Thanks. /huawei >