From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1CF143E83; Tue, 16 Apr 2024 09:19:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1264D402D0; Tue, 16 Apr 2024 09:19:23 +0200 (CEST) Received: from fhigh3-smtp.messagingengine.com (fhigh3-smtp.messagingengine.com [103.168.172.154]) by mails.dpdk.org (Postfix) with ESMTP id 5A3D140293; Tue, 16 Apr 2024 09:19:21 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 9ABD61140171; Tue, 16 Apr 2024 03:19:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 16 Apr 2024 03:19:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1713251960; x=1713338360; bh=/jvDU6xf5qPDVsYcpCvzJHTLEqMe1Nr4oLglkWNeUbI=; b= UZjJDP86t08z663m8dwpDt824XgY2VQYLR5law+bbKG0WxsoRUmTc2ZMt3f0mbHa 2J3hqM6x3kc0ExMA6Np9z1/u0G3I/TgKD4/Xskl6zT0jX5mJAbTxJx0bLyApntr1 oPtcbNVsmnJSoCJjZegDY2jNgco2bOHFWf3pRVUfmLidqbXULZRdLAR3OAqOuz4L pMpJig3n4BnW2ImgUGWGzcSlNe3dDmQxe1s4B833nKKTdao+JsXpzDWlmwzIl6pX R1iJ1dNfLT03pdhOTM7kP7w8Qoiv+Dl57cOhOvFNPxTPqAndoXZPqRCTYwfVeofc txAwT1iUECC0vDaZFcqd3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1713251960; x= 1713338360; bh=/jvDU6xf5qPDVsYcpCvzJHTLEqMe1Nr4oLglkWNeUbI=; b=q 5eg20687jqLP/6fChybNEC03ZUrlTWPUNeCQ4mnJugk4acgOMb32dZOL6+wayYrC GfY3z+psAZNSTnB+gOKjD/QKSsYM/2VOxtOcfxqNtX83hZKZaRF+YB5oVTKy1Ilf kOR+kZS6GpP2fI6gZPbCbWvM4YcpMe3L9mIwxHD7XTEPo5SMmUkF07R3SSy7c74v aTilCE+a1j4cN/SW7EINFtWEYDpSqaFOBMoJXdsZiFbEGlPEC53UagcOH9S1BpKW IYs7jKQDOqB1xZ2tb/wtAF/r699s53FCWYKNPuZE45wf5jvU/AidrLuYU/RnYNfY f4M3YaiWrVNCn8u1a3+FA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudejfedguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepfefhjeevudegheeitdefgfetledufeeuvdekleegfeelhfef hfetgeffuefgveejnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpughpughkrdhorh hgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 16 Apr 2024 03:19:17 -0400 (EDT) From: Thomas Monjalon To: Honnappa Nagarahalli , ci@dpdk.org Cc: Aditya Ambadipudi , "ci@dpdk.org" , Dhruv Tripathi , Wathsala Wathawana Vithanage , Paul Szczepanek , nd , Ali Alnubani , Aaron Conole , dev , Patrick Robb Subject: Re: How to remove a word from the dictionary.txt we are using in the CI/CD pipeline. Date: Tue, 16 Apr 2024 09:19:14 +0200 Message-ID: <2930899.e9J7NaK4W3@thomas> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org We have such exception already: devtools/build-dict.sh 16/04/2024 00:19, Patrick Robb: > Hi Aditya, >=20 > I don't run these CI checks, but I think the checkpatch script in CI > is using https://github.com/codespell-project/codespell as the > dictionary provider. So, one possibility is suggesting to that project > that deque is a valid word which should be supported in software > projects. Then, the person who maintains this check would have to > update their codespell repo. I haven't tried submitting such a change > to this project before, but it looks like they have some open PRs for > word policy suggestions like yours: > https://github.com/codespell-project/codespell/pull/2812 >=20 > It looks like the first and fourth from this list would need to become > valid uses? >=20 > ./codespell_lib/data/dictionary_code.txt:deque->dequeue > ./codespell_lib/data/dictionary.txt:dequed->dequeued > ./codespell_lib/data/dictionary.txt:dequeing->dequeuing > ./codespell_lib/data/dictionary.txt:deques->dequeues >=20 > Ali, are you the person who maintains the checkpatch run which posts > results to patchwork? >=20 > Otherwise I think it is up to the DPDK maintainers to decide if an > exception is appropriate. I believe they have done this in the past. > It might not hurt to suggest the change to codespell, and then if > they're not on board, requesting an exception for your DPDK patch. >=20 > One possibility is starting a DPDK specific exceptions list, which > people could add to alongside their patches. I don't think the > maintainers will favor this though as I expect they will want to keep > checkpatch pretty simple and standard. >=20 > Adding the dev mailing list as I'm guessing other DPDK devs have run > into the same issue and might be able to provide more feedback. >=20 > On Mon, Apr 15, 2024 at 5:17=E2=80=AFPM Honnappa Nagarahalli > wrote: > > > > + Patrick > > > > > > > > From: Aditya Ambadipudi > > Date: Monday, April 15, 2024 at 3:41=E2=80=AFPM > > To: ci@dpdk.org > > Cc: Honnappa Nagarahalli , Dhruv Tripathi= , Wathsala Wathawana Vithanage > > Subject: How to remove a word from the dictionary.txt we are using in t= he CI/CD pipeline. > > > > Hello folks, > > > > My name is Aditya Ambadipudi. I work as a software engineer at Arm. > > > > Recently we submitted a patch set for DPDK: > > > > http://patches.dpdk.org/project/dpdk/patch/20240401013729.1466298-3-adi= tya.ambadipudi@arm.com/ > > > > And the CI/CD is failing for this patch because of the word Deque. > > > > 1787:adaquate->adequate > > > > 1788:adaquately->adequately > > > > 1789:adaquetely->adequately > > > > 1790:adaquit->adequate > > > > 1791:adaquitly->adequately > > > > 1975:adecuate->adequate > > > > 1977:adequat->adequate > > > > 1978:adequatly->adequately > > > > 1979:adequit->adequate > > > > 1980:adequite->adequate > > > > 1981:adequitely->adequately > > > > 1982:adequitly->adequately > > > > 18484:dequed->dequeued > > > > 18485:dequeing->dequeuing > > > > 18486:deques->dequeues > > > > 30005:inadiquate->inadequate > > > > 30006:inadquate->inadequate > > > > 61309:deque->dequeue > > > > > > > > > > > > Code spell wants us to substitute all the places where we used the word= "deque" with "dequeue". > > > > > > > > We were wondering if it is possible to remove this rule from that dicti= onary that the CI/CD pipeline uses. Or if there is a way to circumvent tha= t rule. > > > > The CR we created was specifically to add a Deque library to DPDK. The = data structure we have created is a Deque and there is no other word that w= e can think of that describes that data structure better than "Deque". > > > > > > > > Thank you, > > > > Aditya Ambadipudi > > > > > > >=20