From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 36963A0512;
	Wed,  3 Jun 2020 12:16:57 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 6E6DE1C21F;
	Wed,  3 Jun 2020 12:16:56 +0200 (CEST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1E0C21C1E9
 for <dev@dpdk.org>; Wed,  3 Jun 2020 12:16:54 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
 by mailout.nyi.internal (Postfix) with ESMTP id 84AA95C0092;
 Wed,  3 Jun 2020 06:16:54 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute7.internal (MEProxy); Wed, 03 Jun 2020 06:16:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm1; bh=
 bTppjYIzkiIKvx25fFs+vdJkBTyR/J6Kl9ceQ/ZpW4c=; b=Uh2CyKune9k0vHrm
 lve0zXL257JTGkBEiesOadFZ/kqNMGmMJ8owxY6aLjTeXpAYqN+4iMSFV1OoSgha
 Vdg9psx6pmRMF1QRekoR8c/nJFadwNXq2MkDnJ8+LA9MtYbK1V7LZDnCHTyQlAiR
 TTs/S+T9zi95IQhe2GbToppgIBk7CrurybEcRdVa7wq+xCfo1NLZ3+mGIe5LPjPu
 pbwPVZKNS6hxe/74YyVZKMaM3SJO6l+iYLxe7r/rFSTAPMUB5oABoJJg3rf9oE0A
 DwCxMVwBIl3pNquYf9l/Ykkvaor5fWqCtf+2NFy/tdP4zXTQBMOSFLRE+GODUSwb
 MZWH2w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=bTppjYIzkiIKvx25fFs+vdJkBTyR/J6Kl9ceQ/ZpW
 4c=; b=pMxcvPbOZPtogVZA7YLYZ45PwZ5uYHBlNf2hn5YERGSUQjxM7tFrKmkkS
 SmnSkVrm3Y+HLPF3gc7uvlQI3nfe3ZWOSb1GIm99UUi90NPXOcFL6fYFqfDleZ6g
 fozNDbN7P1tIb34vP7Vva6WCs6Jw8lGIBsXsahZgg2fORjbCGAKcc3NB2nVYbrxO
 oHzfUKKuQLsIwHDd7HQMnM+X8AqvFrTh6MTk+zh5e7Ff1LeXww3rxxfU70a/mOo1
 tcxS1NbFf5RmA5gKhXw5e0Yp508Ao26bEaFKPESFNYCjHT6JwX8XA5ycdv3tdgaH
 TXD+Nv6T9Ep5Cpufc9PqDswbgeLbw==
X-ME-Sender: <xms:lXjXXk17l94-3xkQiWZC36ml3pT4cuaVqNivHXTjGnFOQRf3SI0JBw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefledgudekucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu
 tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:lXjXXvHJOJiVgcpfnkJQpHXxQUfFArGU1CzEG3gJ0CVzZhLWl126NQ>
 <xmx:lXjXXs7ZKPVhZpC-1rvMQz8gKnmyzzVCbbe5sYj16fQu03DWadpSyg>
 <xmx:lXjXXt0838hsC2ktUBq2l2pdGXZs5mVE7WDkzQUwEjoiVurJ5q7vlw>
 <xmx:lnjXXqMino5bb6fhJ1eiv4BIJfIU2lJYmkbxDJvZQDy7kmzrHUPYHA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 63C4A306215A;
 Wed,  3 Jun 2020 06:16:53 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Juraj =?utf-8?B?TGlua2XFoQ==?= <juraj.linkes@pantheon.tech>
Cc: ferruh.yigit@intel.com, arybchenko@solarflare.com, dev@dpdk.org
Date: Wed, 03 Jun 2020 12:16:52 +0200
Message-ID: <2931549.x8W8VkzX4A@thomas>
In-Reply-To: <1591177738-32338-1-git-send-email-juraj.linkes@pantheon.tech>
References: <1591177738-32338-1-git-send-email-juraj.linkes@pantheon.tech>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/06/2020 11:48, Juraj Linke=C5=A1:
> Directive #include <file> in gcc implementation searches for files
> in a standard list of system directories, which leads to a sporadici
> build error on Taishan arm machines:
> /tmp/openvpp-testing/dpdk/lib/librte_ethdev/rte_ethdev.h:4287:10:
> fatal error: rte_ethdev_core.h:
> No such file or directory #include <rte_ethdev_core.h>

Would be interesting to know why nobody else hit such error?


> Fix this by replacing the directive with #include "file" which searches
> for files first in the directory containing the current file and other
> directories only after that.
>=20
> Signed-off-by: Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech>

What about #include <rte_ethdev_trace.h> ?

Except this,
Acked-by: Thomas Monjalon <thomas@monjalon.net>


I would change the title to be more generic (nothing specific to gcc or Arm=
 here):
	ethdev: fix local include

It needs to be backported, so these lines are required:
	Fixes: 7f0a669e7b04 ("ethdev: add allocation helper for virtual drivers")
	Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers")
	Fixes: ffc905f3b856 ("ethdev: separate driver APIs")
	Fixes: 331c447ad913 ("ethdev: separate internal structures into own header=
")
	Cc: stable@dpdk.org