From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24B52A00C5; Sun, 5 Jul 2020 11:00:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFF451DA92; Sun, 5 Jul 2020 11:00:13 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 13F0D1DA86 for ; Sun, 5 Jul 2020 11:00:13 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 926A958016F; Sun, 5 Jul 2020 05:00:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 05 Jul 2020 05:00:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= fJ0H5jxh8xDJ5c5u3tzO6theH7POD85DpQA4BbUs89s=; b=RVpdiuIm/BU79mtQ WkmhZKODkV7MVRaFXjeqUm278VFR79Tycjj7tlCjGK6H/nODIwYj8uSuiRASA1un Q0SnTNNZD23O+yqWufJ4wHR+SlN048Fvc52IYyLLvSgJ9bPnH5WK+q1jcbZf9eNQ UgqotLLX7vUW+ErF5Rq3uvOIKKginFWz2e4/hR5WPsl8nlEgsOK6w//+tE72xITJ zZrbQLFd+eFsxnJRRZbkeVLODdgiHSDHO+5ZydP1KZ0UHlnbnOCGFVPKJ0xEsrbJ dNtTV/KeYhUtU0fg/cIJhuurdk4Cg96nFu8f1YufL2tcggYF20HR9SKlyYawzidR efrCQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=fJ0H5jxh8xDJ5c5u3tzO6theH7POD85DpQA4BbUs8 9s=; b=lVuk5ETeyoJhEeRwmm2YUo+R8NmaoenSkCm2I3xJ+6tg+Wr+aVfwaNO/a SBnBGaw31rJdKUEm/T7knGzOqkPYHfm5ddTg8C0/iZ4nv/TVdGNZrumc5XumwDjd bdZxBT+hfUVQX1QBBH5agrvKXd2VD3bgFnusz1pf9vP04/k2D/oc2F3SftyduNFo 4S9jPgKcoaIt1p23jIkcH4QXLMzzb89vwDVa4afh/VeDgi0M8BZCwhDLKy1o6WUo rJ90JLPJttMF9oJVaIkcPsQaM9ucl1YPnDPd6o7w/QT3GxRORtMVwrq6sxF85trR 9Vu6T56yHx1TKcSGAaTnDfrZeKu6A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddugdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeeileekuddvkeehtdeivddufeevfeegveffheejfefhtddttdejhfel gedtleegtdenucffohhmrghinhepmhgvshhonhdrsghuihhlugenucfkphepjeejrddufe egrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A8A273280059; Sun, 5 Jul 2020 05:00:10 -0400 (EDT) From: Thomas Monjalon To: "Kinsella, Ray" , Fady Bader Cc: "dev@dpdk.org" , Tasnim Bashar , Tal Shnaiderman , Yohad Tor , "dmitry.kozliuk@gmail.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "pallavi.kadam@intel.com" , "ranjit.menon@intel.com" , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "nhorman@tuxdriver.com" Date: Sun, 05 Jul 2020 11:00:09 +0200 Message-ID: <29324685.utGxs7hIzm@thomas> In-Reply-To: References: <'20200531124151.16848-2-fady@mellanox.com'> <4076841.gji8TSPR8A@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/07/2020 10:51, Fady Bader: > From: Thomas Monjalon > > 05/07/2020 09:00, Fady Bader: > > > > On 30/06/2020 11:49, Kinsella, Ray wrote: > > > > > On 22/06/2020 12:55, Fady Bader wrote: > > > > >> --- a/lib/librte_eal/include/rte_function_versioning.h > > > > >> +++ b/lib/librte_eal/include/rte_function_versioning.h > > > > >> @@ -11,6 +11,10 @@ > > > > >> #error Use of function versioning disabled, is > > "use_function_versioning=true" > > > > in meson.build? > > > > > Do we need a meson error/rule that catches if people explicitly > > > > > try to enable > > > > function_versioning. > > > > > We don't want to just silently fail under such circumstances? > > > > > > > > > > Would something in lib/meson.build would work better? > > > > > > > > > > if use_function_versioning and target_machine.system == "Windows" > > > > > // complain loudly ... > > > > > endif > > > > > > > > > > > I think this would be a better approach. > > > But instead of checking if the use of function versioning is enabled > > > under Windows and then complain, I think we should simply disable it > > > from Windows in the meson.build file. Something like this: > > > > > > if target_machine.system == "Windows" > > > use_function_versioning = false > > > endif > > > > Did you try? > > > > If you disable function versioning, compilation will fail with the #error message > > above, right? > > > > Yes, the compilation fails, we can also change the rte_function_versioning.h > code in order not to fail under Windows. > What do you think ? Function versioning CANNOT be supported currently on Windows. Function versioning macros are MANDATORY in some libraries. That's why I think the only path is to have a specific implementation of the function versioning macros for Windows.