From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 498E945459; Wed, 19 Jun 2024 22:12:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15806402C6; Wed, 19 Jun 2024 22:12:16 +0200 (CEST) Received: from fout4-smtp.messagingengine.com (fout4-smtp.messagingengine.com [103.168.172.147]) by mails.dpdk.org (Postfix) with ESMTP id 26A2B402B8; Wed, 19 Jun 2024 22:12:15 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id B3C8A1380225; Wed, 19 Jun 2024 16:12:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 19 Jun 2024 16:12:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1718827934; x=1718914334; bh=qnvUvZ7pKCsQ3Dg1iBA3FAQSYAGrWMQce66Lb2DZiKY=; b= aAIbW6drFoS3gJ2T/p0o/DDY11zglr1tPieUPt+2ePAoX3MF8SdXZXTnfJicCZRk vZoN+uzPth9Xln4btjdAlgG3mjJ8fbIseDMss4dZxSZuIvy76Ag5us9jcy7T12F/ gvo1QEg6V1X9NW4w3k8O9t7ewosGYnqSpVtf5khyiSLX9p3UiV0ut/yPRqsQMMG3 v/SyBFraptBvzJ1BKxQVfbzmFgvzPMuXCzHBb7XRpdk/xOaGks5WpNGpMjLHhyoM fUq2Rs1wvWm6FZgp1LxA+kEIxJaV4Bp7iCqZRFdLbISGitJUMS7ugucWxgmZ4hc7 HIszWRH2hX8tTxXMHUPxuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1718827934; x= 1718914334; bh=qnvUvZ7pKCsQ3Dg1iBA3FAQSYAGrWMQce66Lb2DZiKY=; b=g 3ofSg9fULTOl3XK1sAVq8H8iTzjXPikVXVvYzd2gnG4hXEEOiNrClZOsINYU8S50 MkV0ENGB3nQjG2Wk6QG4Vf0eOF5GlB6thXnQ2Grkr7ZwpOAmilAb6tJNhIeTpflH pu1s5lbMMWTtOwi3XBl7RHTsou6yy6bl0eiCst3iPjUil0YSuXW7rosPe8OlJ8Fv AicBJG8kd7aDAiiTY0/AeNT4Fx/TltjN3Ocq6pXkdqsunVVnA1mVhR3gHJWNP5i8 jntqN0wqL1m1JsE8LmZmo70mfabALBfItth6WpB11mkpIZJSTuZJ061zQb5D0BSX r+HYDjuaFFeu0b7SMgBdQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeeftddgudeghecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeeg kefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Jun 2024 16:12:13 -0400 (EDT) From: Thomas Monjalon To: Mingjin Ye Cc: dev@dpdk.org, stable@dpdk.org, Anatoly Burakov , david.marchand@redhat.com, stephen@networkplumber.org, bruce.richardson@intel.com Subject: Re: [PATCH 1/3] bus/vdev: revert fix devargs in secondary process Date: Wed, 19 Jun 2024 22:12:12 +0200 Message-ID: <2935664.e6Ti0vRb3T@thomas> In-Reply-To: <20240314093630.1066948-2-mingjinx.ye@intel.com> References: <20240314093630.1066948-1-mingjinx.ye@intel.com> <20240314093630.1066948-2-mingjinx.ye@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/03/2024 10:36, Mingjin Ye: > The asan tool detected a memory leak in the vdev driver > alloc_devargs. The previous commit was that when inserting > a vdev device, the primary process alloc devargs and the > secondary process looks for devargs. This causes the > device to not be created if the secondary process does > not initialise the vdev device. And, this is not the > root cause. > > Therefore the following commit was reverted accordingly. > > Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process") > > After restoring this commit, the memory leak still exists. > A new patch has since fixed this issue. > > Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process") > Cc: stable@dpdk.org > > Signed-off-by: Mingjin Ye Applied The rest of the series is not cleared enough to be applied. We need more precise explanation of the problem to solve, and some good reviews please. At this stage I'm confident enough only for this revert.