Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-02-20 20:23, Dumitrescu, Cristian:
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > On Fri, 20 Feb 2015 18:32:03 +0000
> > "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> wrote:
> > 
> > > Stephen, I suggest adding a new build-time configuration option for the
> > > librte_sched library in config/common_* files:
> > > CONFIG_RTE_SCHED_STATS_CLEAR_ON_READ.
> > 
> > Build time config options do not work for distributions.
> 
> Why?
> 
> This does not affect the API, as the new API functions are always compiled
> in, and the prototypes are not changed, and no data structures are affected.

Behaviour is an important part of the API. Think comments as part of the API.

> This only changes the behavior of certain functions, so that user can
> select which mode it needs.

When user doesn't or cannot rebuild, he has no choice.

> It also preserves backward compatibility.
> 
> We have so many compilation options in config file, why is this one different?

We must remove and avoid build-time options.
The only ones which might be acceptable are the ones which allow more
performance by disabling some features.

> This e-mail and any attachments may contain confidential material for the
> sole use of the intended recipient(s). Any review or distribution by others
> is strictly prohibited. If you are not the intended recipient, please contact
> the sender and delete all copies.

Please ask to your administrator to remove this disclaimer.