From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f178.google.com (mail-we0-f178.google.com [74.125.82.178]) by dpdk.org (Postfix) with ESMTP id 8AF3DB7A1 for ; Fri, 20 Feb 2015 22:01:40 +0100 (CET) Received: by wevm14 with SMTP id m14so7769577wev.8 for ; Fri, 20 Feb 2015 13:01:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=DXIGp7AKUxguLhWnryaCzVNuAQB5gMvynqQHzQ7WJ9s=; b=ZwBINxq87YAn/zjxonJxWTRtu+ZZuMwNtTTRltwiWiD59a/aW4VJvheg1y6MTEkjK/ kUlxJFFBksN+cibkwtkEj+40meUKcNKsyDuDtTBTaBkmC0xhzueKy391/IOkGMC8y3n5 uetjZ9pyC2HP4kB0uY2o97DFr0KEuA+Er9s1gcL9mXFH10TCCvTTSDCm6EpfeNCQf9c4 0nKkPcfX0M2y8iSRzxTYinp0Bw60ihYwrlnt06kWAhL+/ZYQkTozi92Iv+dxstLi792d scCVF38MTEgqf4NRySBLVdiesnhGwIkkveng53SnAqA+5xsUjevO02c0mg6iQ/C44r3Q BgXg== X-Gm-Message-State: ALoCoQlQLQr9bkn0Njj0jgqwgKD1F+EU2GWz5tuAjXNEdhmoqzA+eAig0ctKc/DOjr38fWPhaBzb X-Received: by 10.180.212.113 with SMTP id nj17mr1302414wic.54.1424466098892; Fri, 20 Feb 2015 13:01:38 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dj4sm43699433wjc.13.2015.02.20.13.01.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 13:01:38 -0800 (PST) From: Thomas Monjalon To: "Dumitrescu, Cristian" Date: Fri, 20 Feb 2015 22:01:08 +0100 Message-ID: <2937997.VuavGYZbL6@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891263231B33C@IRSMSX108.ger.corp.intel.com> References: <1423116841-19799-4-git-send-email-stephen@networkplumber.org> <20150220115256.7557e716@urahara> <3EB4FA525960D640B5BDFFD6A3D891263231B33C@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics when read X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 21:01:40 -0000 2015-02-20 20:23, Dumitrescu, Cristian: > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > On Fri, 20 Feb 2015 18:32:03 +0000 > > "Dumitrescu, Cristian" wrote: > > > > > Stephen, I suggest adding a new build-time configuration option for the > > > librte_sched library in config/common_* files: > > > CONFIG_RTE_SCHED_STATS_CLEAR_ON_READ. > > > > Build time config options do not work for distributions. > > Why? > > This does not affect the API, as the new API functions are always compiled > in, and the prototypes are not changed, and no data structures are affected. Behaviour is an important part of the API. Think comments as part of the API. > This only changes the behavior of certain functions, so that user can > select which mode it needs. When user doesn't or cannot rebuild, he has no choice. > It also preserves backward compatibility. > > We have so many compilation options in config file, why is this one different? We must remove and avoid build-time options. The only ones which might be acceptable are the ones which allow more performance by disabling some features. > This e-mail and any attachments may contain confidential material for the > sole use of the intended recipient(s). Any review or distribution by others > is strictly prohibited. If you are not the intended recipient, please contact > the sender and delete all copies. Please ask to your administrator to remove this disclaimer.