From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFE30A0524; Tue, 13 Apr 2021 18:39:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B94D616118E; Tue, 13 Apr 2021 18:39:36 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id D447116115C for ; Tue, 13 Apr 2021 18:39:34 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 3F9CD580800; Tue, 13 Apr 2021 12:39:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 13 Apr 2021 12:39:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= wWMOrhOTMe8L6ghdO9QiccpUel82dO9M1i9gCKUlqGU=; b=oqzCNdadvcblQtt4 xNS+xvAxkMyCQtsIpPGsFr4Sep2F3toEaI03jHflB0Jm5nAiO5dYWIbYmlSWARaI XXUyL7SH5EggnKLdYR//zJMDN3KQLoECzW39SdUwb6+p7geJl7cmzt1CCpF7SU2x i2pbxqz901jna4jPe5+uF69LdYzTWcmxZbMk9z5Wz852d7bgI0MmK8L+nlVnml+y ybfWv7n4jtNArKp+ZE1oaP6A3u4vCc0oob88QMGJzq7KDNJVzwAsHBkwk2kbugKo p0TgAI7g+P9sEQ/EFGhAgWwiYJZtBllDzg5JBjEPvHVih4G7HYl6SmFyQEh6Z0Cv 1cGVng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=wWMOrhOTMe8L6ghdO9QiccpUel82dO9M1i9gCKUlq GU=; b=De7t5Lk4gaRuBXQjEBfL6z2OpAaqGNPWO/70nLq74h9qHBW94vjq4Wl2J QsWOKp0PvsEzv5zaOjn5buY6bRcwigzVh0vyZvZm2tQiLM4Q/S+RtfdZQv5O5gva i84nFVIaBrT3fH7diTAgVL6VX2Hi3F04n3KRAxB8RsPT54V/92PmzLty2J66XVY4 Q/6zLIFDDP26racawl2v96ol6YdbIBliLP0HUHvmK4dv45ucSaKK1kPt9jUpABow oMvSqvqks0wXMoYRv+dbtKvIz5CKMtrz5zxbk7N0Nx9jWPg2XHD3Z7pj0Bgry1rU qDFqh+GZObbdoQXRr0EOM6vl7uhKQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekledguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0E8B724005C; Tue, 13 Apr 2021 12:39:27 -0400 (EDT) From: Thomas Monjalon To: Matan Azrad , Ray Kinsella , Declan Doherty , Akhil Goyal Cc: "dev@dpdk.org" , Somalapuram Amaranath , Ruifeng Wang , Ajit Khaparde , Anoob Joseph , Fan Zhang , John Griffin , Pablo de Lara , Michael Shamis , Nagadheeraj Rottela , Ankur Dwivedi , Gagandeep Singh , Jay Zhou , ArkadiuszX Kusztal , "sashakot@nvidia.com" , "oren@nvidia.com" , Shiri Kuzin , david.marchand@redhat.com Date: Tue, 13 Apr 2021 18:39:26 +0200 Message-ID: <2938273.EbuWGXm2bp@thomas> In-Reply-To: References: <1615724283-26149-1-git-send-email-matan@nvidia.com> <20210404150809.2154241-1-matan@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: support multiple cipher data-units X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/04/2021 14:02, Akhil Goyal: > > All the new fields do not change the size of their structures. > > Please check that the CI is failing. I see that ignore exception is present in > devtools/libabigail.abignore For rte_cryptodev. But not sure why this is still > failing. Can you check? There are 2 new fields: - rte_cryptodev_symmetric_capability.cipher.dataunit_set - rte_crypto_cipher_xform.dataunit_len This is how the struct sizes are affected (before / after): struct \ arch | 32-bit | 64-bit | -----------------------------------|---------|---------| rte_cryptodev_symmetric_capability | 36 / 36 | 36 / 36 | rte_crypto_cipher_xform | 20 / 24 | 32 / 32 | There is no change in rte_cryptodev_symmetric_capability because the field is added in a light branch of the union. The 64-bit size of rte_crypto_cipher_xform is unchanged (32) because there were 4 padding bytes at the end (28 + 4). But the 32-bit version has not such padding at the end, so there is a breakage. The only hole in 32-bit rte_crypto_cipher_xform is 2 bytes between key and iv. Can we define dataunit_len as uint16_t? The other side to check when playing with the ABI is the default value of the holes for the new field. The driver must work properly in case the application did not explicitly set the new fields. In general it means the compatible API should have memset(0). In this case, it seems the new fields will be used only in a new mlx5 driver, so it should be OK for now. But usage of the new fields in an existing driver must be checked carefully during the compatibility period.