From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABF58A034F; Tue, 23 Feb 2021 21:25:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B1AF4068C; Tue, 23 Feb 2021 21:25:33 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id A1ABB4068B for ; Tue, 23 Feb 2021 21:25:31 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 0D9B95803AF; Tue, 23 Feb 2021 15:25:31 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 23 Feb 2021 15:25:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= toqt1zFBiJfnfKGD9DloZbjw/L3oVQXrad2lx0tIE0A=; b=GGJnZybgoJE7Ah53 uYPK5l5w972H6sZbWiOfr9RVRX4nldgysH9Gr53+zub21PQqWBGoubIYlZXqAOab i1arBI70gYVrP30EvCM4K2WyguZVfno02ttYp06LTF1V5MSPPAmCvJNJ/9YWofH5 lZoOad+227Le5AxTEtMqYQxaDRDjfRi6JxH4NXjWmwrFvsY8jA0XEhSDi8jySuX4 LzbKbqOaCYl3HznnFQQVeSvOrMORfhzNR1pWAeWS0OKGKKEOzdeXpQikS6vHFCKC eyHTcuCVVc50b1+Gtg9zA+4ezhjxowDy4/RTsRiQpvWmEo1aX55flpSCkjFQ83QR aVDxrg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=toqt1zFBiJfnfKGD9DloZbjw/L3oVQXrad2lx0tIE 0A=; b=JN7EGPGWPsjwp6EQUXQvl1DfZ1mei1f7UJF3aC50XW1QODllsBK8Em7lq t2+amKJ5K+slD7sDghfbnHhCtraN/eRzD45EazLGB+0GOT79cHyRxlGwt0+U/U6e 2AcW/uJUiDDQbWQSLoJcf/Btrna0rAiy+hjaNg32GTIY8ynKOHQb6RSyFXsef9d3 qD+6yLkTMOebzK3MWmBL7y19ymI7sJeK2ByJ4tD0amGlUbeeSYWIEXoFglipxSDX OE9smLBGO+ZgoWRfKGHY7BbBT6tMldwi8QGm9V+BwuNi6GqBB04V7qXeIr/lP/SI Rv0Sv8yA+HKo3Tw3kDIKzL76X6TEA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrkeehgddufeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1DCFC1080063; Tue, 23 Feb 2021 15:25:29 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , Ajit Khaparde Cc: Wisam Monther , Lance Richardson , Wenzhuo Lu , Xiaoyun Li , Bernard Iremonger , Olivier Matz , Andrew Rybchenko , "dev@dpdk.org" , Kalesh Anakkur Purayil Date: Tue, 23 Feb 2021 21:25:26 +0100 Message-ID: <2946497.zBJjzZiKe1@thomas> In-Reply-To: References: <20210129223554.103012-1-lance.richardson@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/02/2021 19:39, Ajit Khaparde: > On Tue, Feb 23, 2021 at 10:36 AM Ferruh Yigit wrote: > > > > On 1/31/2021 11:53 AM, Wisam Monther wrote: > > > Hi, > > > > > >> -----Original Message----- > > >> From: dev On Behalf Of Lance Richardson > > >> Sent: Saturday, January 30, 2021 12:36 AM > > >> To: Wenzhuo Lu ; Xiaoyun Li > > >> ; Bernard Iremonger > > >> > > >> Cc: dev@dpdk.org; Ajit Kumar Khaparde ; > > >> Kalesh Anakkur Purayil > > >> Subject: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum > > >> errors > > >> > > >> Count and display outer IP checksum errors in the checksum forwarder. > > >> > > >> Example forwarder stats output: > > >> RX-packets: 158 RX-dropped: 0 RX-total: 158 > > >> Bad-ipcsum: 48 Bad-l4csum: 48 Bad-outer-l4csum: 6 > > >> Bad-outer-ipcsum: 40 > > >> TX-packets: 0 TX-dropped: 0 TX-total: 0 > > >> > > >> Signed-off-by: Lance Richardson > > >> Reviewed-by: Ajit Kumar Khaparde > > >> Reviewed-by: Kalesh Anakkur Purayil > >> anakkur.purayil@broadcom.com> > > > > > > Acked-by: Wisam Jaddo > > > > > > > Reviewed-by: Ferruh Yigit > > Applied to dpdk-next-net/main, thanks. > > > > > > > > 'PKT_RX_EIP_CKSUM_BAD' is documented in mbuf header as: > > "/** External IP header checksum error. */" > > > > I think 'External' wording is confusing, as well as 'EIP' abbreviation, what do > > you think to create another macro alias to existing one, and mark the old one as > > deprecated? > +1 +1