From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E1AC81B398 for ; Wed, 1 Aug 2018 12:14:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 77B7D234C9; Wed, 1 Aug 2018 06:14:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 01 Aug 2018 06:14:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=UZWyl3TwiRj2pXRxmDVNXEm9uR TekUDfQLvoiyCHxf8=; b=A0eCNLfDmTUwMS9oYGpjv4lHb3ywUYO3VVi+iepVT3 /zJwLEtA/7sIMI9rpcSuGwJbofJgHT5+81HAi0boypnclr3yFlz+GEm+cBNgP+Ob rQtj9/TRVs3JReL+7qt1bJ71fn0yws0H79hfHw7gS/+5rQcYiDQJt5lqR4t7sshw w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=UZWyl3 TwiRj2pXRxmDVNXEm9uRTekUDfQLvoiyCHxf8=; b=JiTGBgUA0onGaD3Fkqi+2N ZlZ4dG3fw3SFMoyH2j4gZPgrU4woRflgMBpcXVcx9q2M7PVo6681dX8VqqsAUg0D GJhCGUqXtLh7KjxNvpKLpuDJvreKQcJhyJnMT6XyUsq13HPtBAyG5IUcjaWBio2s NMbmpv1xA9h79xopbBbgTPEhc4KDXqPF+lf5Fp1Hwv+05hDkhQZCfc8rWXQEaUn4 yabJ8fqj/TDMNj4JJEIQlhW7tzKsf1ecPKPyKr3ghRrTt9s+v5T4KuAb7CBqbGy+ i7RHzFr1d4gdFKvuTBdBIEkDyR8zMdQXgTJzrvxHBLRnnsJigADXikUwrbmo2+Nw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3C6791029A; Wed, 1 Aug 2018 06:14:12 -0400 (EDT) From: Thomas Monjalon To: Reshma Pattan Cc: dev@dpdk.org, anatoly.burakov@intel.com, jananeex.m.parthasarathy@intel.com, Naga Suresh Somarowthu Date: Wed, 01 Aug 2018 09:52:17 +0200 Message-ID: <29483712.ychiUti4Sd@xps> In-Reply-To: <1533075501-10135-1-git-send-email-reshma.pattan@intel.com> References: <1533075501-10135-1-git-send-email-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v10 0/5] add unit tests for bitrate, latency and pdump libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 10:14:14 -0000 01/08/2018 00:18, Reshma Pattan: > v10: fixed clang compiler issues and freed latency stats memzone in laten= cy > stats unit tests. > v9: rebased ontop of latest autotest changes and added new tests to the a= utotest list > v8: renamed commit headline and freed the metrics memzone for bitrate ut > v7: removed unused macros and corrected the comment > v6: updated ring variable appropriately > v5: rebased, freed pools and rings, created common patch set > --- Sorry, the integration of this patchset is very painful. After asking for rebase, for clang fix, there are still some basic errors with 32-bit compilation: test_latencystats.c:131:21: error: format =E2=80=98%ld=E2=80=99 expects argument of type =E2=80=98long int=E2= =80=99, but argument 2 has type =E2=80=98uint64_t=E2=80=99 {aka =E2=80=98long long= unsigned int=E2=80=99} linkage: test@test@@dpdk-test@exe/test.c.o:(.data+0x18): undefined reference to `te= st_pdump' or even MAINTAINERS file: test/test/sample_packet_forward.c test/test/sample_packet_forward.h test/test/test_bitratestats.c test/test/test_latencystats.c I have already spent too much time on it, despite it is not fixing 18.08. Please do a complete detailed review of this series, so it can be considered for 18.11.