From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 9BBBDAA3D for ; Wed, 8 Jun 2016 11:53:10 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id n184so173375426wmn.1 for ; Wed, 08 Jun 2016 02:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=3qREDQqOu7yEKfHryvuCYzsnODjroi5/aJKdjZqAkzU=; b=qKyvP6tV5tz3fa8xY+SEA37RAiiXyyFk6GSnu3roYkKtFgE/ZOCm7VySPCTi4qjRNU iDdb++AYF31DysRojJv/t/HdSky2UJNIcbgmppmPSQcU4RlWJjfukd/UFEpp5+bV74GN tq3zqSiNa6d2hHmSYJo2y/OL0u4sUr4JmHWAbTuPkas8SQ2cJiQcQNpC8hvhzVuHJK6X HD6UbUVTZ36irsFlqbEHeMRfGr2e4LGv2STX0DLUq/aPzs3vAyl1+4BC6m6WTx/PUEZW cnu7Qaeq7oCxSXy5Nru2LtDvlFqu+0jZ2vrZfJ72aSlVEk9ieWjAyaGZeRtGThNgTJ/r zR0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=3qREDQqOu7yEKfHryvuCYzsnODjroi5/aJKdjZqAkzU=; b=j01sRj238RLyx6mIcahCUx3FSwpe0dSMiJomSilibyg51hXBabjODadWWfyw4j213i oqMMw3+6WrcjCXIF7dNGXc2Z8/ZCu/YkUpYNz44uNQGW9WYuJiCNAP//51/4Yqerpz6y tXSKUQOjw6obWrSEBxsBkji2jsf4OAcEmnl0nVcKZKzykiuu8UFBBcRn1LD3IBs7JB0u kAoMY8JOsak1m63XYIZ2hVLBLrAMxohq5NHkim7oX8z6z0DFcJihYcAZ8zA4Q5ZSUf0Y 6ljq+tXXgrvubxWYnAvqnNxEOpuOe1PZR0KwBwAfDKp/mALVwIl4aXbObKh37R5RZUfe kDmA== X-Gm-Message-State: ALyK8tIHbEVcYqcBD5uQZ9zwp24Q9BAxq6haHIG+3G79dVRUoaJql+91/2hh3VnJ9MAaq1Py X-Received: by 10.28.132.144 with SMTP id g138mr6978381wmd.47.1465379590449; Wed, 08 Jun 2016 02:53:10 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id c9sm487429wjh.49.2016.06.08.02.53.09 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 08 Jun 2016 02:53:09 -0700 (PDT) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org Date: Wed, 08 Jun 2016 11:53:09 +0200 Message-ID: <2951960.uL8vF99JUJ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1463563818-2249-2-git-send-email-remy.horton@intel.com> References: <1463563818-2249-1-git-send-email-remy.horton@intel.com> <1463563818-2249-2-git-send-email-remy.horton@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal: add new keepalive states & callback hooks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 09:53:10 -0000 2016-05-18 10:30, Remy Horton: The explanations are missing. Probably you should split this patch. > Signed-off-by: Remy Horton [...] > +enum rte_keepalive_state { > + UNUSED = 0, > + ALIVE = 1, > + MISSING = 4, > + DEAD = 2, > + GONE = 3, > + DOZING = 5, > + SLEEP = 6 > +}; Please use RTE_ prefix. [...] > /** > + * Keepalive relay callback. > + * > + * Receives a data pointer passed to rte_keepalive_register_relay_callback() > + * and the id of the core for which state is to be forwarded. > + */ Please document each parameter. > +typedef void (*rte_keepalive_relay_callback_t)( > + void *data, > + const int id_core, > + enum rte_keepalive_state core_state, > + uint64_t last_seen > + ); [...] > +/** > + * Per-core sleep-time indication. > + * @param *keepcfg > + * Keepalive structure pointer > + * > + * This function needs to be called from within the main process loop of > + * the LCore going to sleep. Why? Please add more comments. > + */