From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id CA823B379 for ; Wed, 27 Aug 2014 17:38:06 +0200 (CEST) Received: by mail-wi0-f173.google.com with SMTP id f8so6029491wiw.12 for ; Wed, 27 Aug 2014 08:42:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=5ceJyFpBMC+1Rg0jf5e5fuSsAaRH9oo8LaQ+V6FMttQ=; b=A7BMkzpRGC/MDUlASdxs6yEd9Rlbb1p4FEQIyo6y8T7JWTUEHfekDjPHfvBA3e8Ltz Co/fbQXwuXYJxszDSCCzOqOkRadyZfu3Co6B6KQS0qeTJQKA7wbZjApwXpV7qgqtlf0p vnPcJnS2RnKvIpXX/l2MTsi5EVhLqGvVn9TazF+zOUhhnpbD4rP6edVMLekBuCY/9Wts /lMgS+WkHHVFXzw9mM8JqEWMDa17bFs2kDW809ELxmnB4zB2cyEh+o/WR+cGa71/I6C8 nKB26+Mi84RAHsjpFziHlbxUbBGqWAddLB6XjcFhQV5YihkdUMoNovBOpUyk318KLwI3 58oA== X-Gm-Message-State: ALoCoQlspx+cMqOQuL8e9mo8ZT8VseFxjFc1+kbzHf5frFAZ7wOQEjuVXJ5j5K4klOvrus+kzrio X-Received: by 10.194.243.230 with SMTP id xb6mr4542872wjc.100.1409154129080; Wed, 27 Aug 2014 08:42:09 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id gk17sm24980689wic.16.2014.08.27.08.42.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Aug 2014 08:42:08 -0700 (PDT) From: Thomas Monjalon To: Helin Zhang Date: Wed, 27 Aug 2014 17:42:02 +0200 Message-ID: <2954869.Rz44bk6IQk@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1405651521-14545-4-git-send-email-helin.zhang@intel.com> References: <1405651521-14545-1-git-send-email-helin.zhang@intel.com> <1405651521-14545-4-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/3] ethdev: improvements for some macro definition in head file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2014 15:38:06 -0000 2014-07-18 10:45, Helin Zhang: > improvements for some macro definition about RSS packet > classification types in rte_ethdev.h. [...] > -#define ETH_RSS_IPV4 ((uint16_t)1 << ETH_RSS_IPV4_SHIFT) [...] > +#define ETH_RSS_IPV4 (1 << ETH_RSS_IPV4_SHIFT) Please explain your change in the commit log. In general, the log should answer to these questions: what was the problem? when the problem was introduced? why it's better now? Thanks -- Thomas