From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 39FAE2BCD
 for <dev@dpdk.org>; Tue,  6 Dec 2016 22:08:08 +0100 (CET)
Received: by mail-wm0-f43.google.com with SMTP id g23so143408843wme.1
 for <dev@dpdk.org>; Tue, 06 Dec 2016 13:08:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=uSDwl6MQZfEbaOCTOMMugeiFEOwqkig1MjqhoWWeiY8=;
 b=sC71L/zZBtGdKLYaHQzLCMPvADR0f5nGVQ5DQm/HtsUN1XzdXni90izmM2HPymOAEI
 mpgaUkj+aIHdV7ZozL4F2w5cbgDFGiF+EV2DA5Hh/zlZNo0VAv97yESROp2gODiVEDI+
 XnGcIZHN2hKLCiGj6GlH0lA7C8EyFlsdM7zbPHWyI/z1aBVdDWemCYlUONVDg2+SR5XC
 zkWy0KkeQKRQJw6QZ2x5EGqoLwfRHzQMO4dCtShbnCP3KKIk1dx+8qqur8JZ3MuBtL+m
 9nm/1yTLb/Lev0DvHE5Lgyk/vEYPJNu0HoqF6QuHFs6/gW5t5TAzl1qm1BTGBRPxgqra
 EAuA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=uSDwl6MQZfEbaOCTOMMugeiFEOwqkig1MjqhoWWeiY8=;
 b=gr2EhqNbnejawI1/i3g3CRUDG0a+JWvMw1qX1DLcJK9+eq7sXE6FHuPmvzeuqGQ/jI
 UMJxNrqzYjlU0D7vO0oDVOnNWc10XgT55LYYOiAYEgI5cd63gG9g3aQaG0jlWr2k9CuC
 Cz7+VHfCiFgQZh/vYl1lext6bfrp5AYU5LJJ3/vDzdFxoTcB7cQA45NyWPaa5OU0g2T2
 3U8P16aUNymRcZQ90bB4XhmNe3v964liiCJvzUIyh/7QKgSRDuRCR2utPFKgpPrgM9QJ
 gVGo+/PwO5gxJmaX8z/lLApcFpH3Pktp/TWEDDxoU7sCOSxa+yKQVLg/yxIiM6tNAZ2f
 wK1w==
X-Gm-Message-State: AKaTC02xzTEuA9gPbHbVCgNBYOMrdnl1a8dVvOd7oMTOAqikbnHLjgxdIbdwvX2bYzlsczCu
X-Received: by 10.28.111.139 with SMTP id c11mr435935wmi.139.1481058488613;
 Tue, 06 Dec 2016 13:08:08 -0800 (PST)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id r138sm5958502wme.9.2016.12.06.13.08.06
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 06 Dec 2016 13:08:07 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, shreyansh.jain@nxp.com
Date: Tue, 06 Dec 2016 22:08:05 +0100
Message-ID: <2956951.cEfl6HOu1U@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <2023a9a6-f342-8986-7ded-3703b3623a70@intel.com>
References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com>
 <1480875447-23680-19-git-send-email-hemant.agrawal@nxp.com>
 <2023a9a6-f342-8986-7ded-3703b3623a70@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 18/32] net/dpaa2: introducing dpaa2 pmd driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Dec 2016 21:08:09 -0000

2016-12-06 19:49, Ferruh Yigit:
> On 12/4/2016 6:17 PM, Hemant Agrawal wrote:
> > +	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> > +		eth_dev->data->dev_private = rte_zmalloc(
> > +						"ethdev private structure",
> > +						eth_drv->dev_private_size,
> > +						RTE_CACHE_LINE_SIZE);
> > +		if (eth_dev->data->dev_private == NULL)
> > +			rte_panic("Cannot allocate memzone for private port"
> > +				  " data\n");
> 
> Should this error kill all app, or return an error for this PMD that is
> probed.

It cannot be a question :)
rte_panic() inside libs or drivers is forbidden (and existing ones must
be removed).