From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CDC946280; Thu, 20 Feb 2025 17:40:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35C03402B2; Thu, 20 Feb 2025 17:40:01 +0100 (CET) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id E75E540292 for ; Thu, 20 Feb 2025 17:39:59 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4YzJnK6GyzzHr8L; Fri, 21 Feb 2025 00:36:53 +0800 (CST) Received: from kwepemf100008.china.huawei.com (unknown [7.202.181.222]) by mail.maildlp.com (Postfix) with ESMTPS id 3721D1401F4; Fri, 21 Feb 2025 00:39:56 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by kwepemf100008.china.huawei.com (7.202.181.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 21 Feb 2025 00:39:54 +0800 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Thu, 20 Feb 2025 17:39:52 +0100 From: Konstantin Ananyev To: Stephen Hemminger , "lihuisong (C)" CC: "dev@dpdk.org" , "thomas@monjalon.net" , "david.hunt@intel.com" , "anatoly.burakov@intel.com" , "sivaprasad.tummala@amd.com" , liuyonglong Subject: RE: [PATCH] power: use hugepage memory for queue list entry structure Thread-Topic: [PATCH] power: use hugepage memory for queue list entry structure Thread-Index: AQHbUezKxRn4I6S/S0+UBKv0KpGojbNQN46AgAB4KgCAABe7sA== Date: Thu, 20 Feb 2025 16:39:52 +0000 Message-ID: <295b2b64b39c4a61b76158e4ff474e40@huawei.com> References: <20241219075319.8874-1-lihuisong@huawei.com> <01d163c6-6d18-03e8-ac67-e7907d27bd08@huawei.com> <20250220081158.345f09b0@hermes.local> In-Reply-To: <20250220081158.345f09b0@hermes.local> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.195.35.39] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, February 20, 2025 4:12 PM > To: lihuisong (C) > Cc: dev@dpdk.org; thomas@monjalon.net; david.hunt@intel.com; anatoly.bura= kov@intel.com; sivaprasad.tummala@amd.com; > liuyonglong > Subject: Re: [PATCH] power: use hugepage memory for queue list entry stru= cture >=20 > On Thu, 20 Feb 2025 17:01:53 +0800 > "lihuisong (C)" wrote: >=20 > > > The queue_list_entry structure data is used in rx_callback of io path > > > when enable PMD Power Management. However its memory is currently fro= m > > > normal heap memory. For better performance, use hugepage memory to > > > replace it. > > > > > > Signed-off-by: Huisong Li >=20 > How is that in a hot path where this could matter? AFAIU - it is used in RX/TX callbacks that power library installs, so I presume will get hit on every eth_rx_burst/tx_burst calls. > The safety rails in rte_malloc() are much less than regular malloc(). > I prefer some degree of safety from checkers and malloc library internals= . Didn't get your point - what's suddenly wrong with rte_malloc()? =20