From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jan Viktorin <viktorin@rehivetech.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [[RFC PATCH]] lib/ether: fix 16-bit unaligned access
Date: Tue, 08 Dec 2015 21:57:33 +0100 [thread overview]
Message-ID: <2962709.1B5sjFu2MI@xps13> (raw)
In-Reply-To: <20151208215504.3c2de0c8@jvn>
2015-12-08 21:55, Jan Viktorin:
> On Tue, 08 Dec 2015 21:30:03 +0100
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>
> > 2015-12-08 20:29, Jan Viktorin:
> > > (I considered to not add the cover-letter as this is just a single small patch.
> > > I hope it does not matter a lot. Is there any convention how to do this?)
> >
> > The main interest of splitting patches or adding a cover letter it to have
> > a place to explain the changes. When you have several changes, they deserve
> > several patches to provide an accurate explanation. In such case, you may
> > need a cover letter to describe the global idea of the series. A cover letter
> > is also helpful for mail threading and acking all the series.
> > When you have only one change, one email is enough.
>
> That's good. Should there be a way how to separate the "inline-cover"
> and the commit?
Do you mean how add a comment which won't be in the git tree?
You can put whatever between the 3 dashes and the diff.
next prev parent reply other threads:[~2015-12-08 20:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 19:29 Jan Viktorin
2015-12-08 20:02 ` Stephen Hemminger
2015-12-08 20:53 ` Jan Viktorin
2015-12-08 20:30 ` Thomas Monjalon
2015-12-08 20:55 ` Jan Viktorin
2015-12-08 20:57 ` Thomas Monjalon [this message]
2015-12-08 21:17 ` Jan Viktorin
2015-12-09 15:16 ` [dpdk-dev] [PATCH 1/1] arm: set CONFIG_RTE_ARCH_STRICT_ALIGN=y for armv7 target Jan Viktorin
2016-02-29 15:14 ` Thomas Monjalon
2016-02-29 15:55 ` Jan Viktorin
2016-02-29 17:13 ` Jan Viktorin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2962709.1B5sjFu2MI@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).