From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 72DC15683 for ; Tue, 8 Dec 2015 21:58:48 +0100 (CET) Received: by wmec201 with SMTP id c201so230541797wme.0 for ; Tue, 08 Dec 2015 12:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=2454LkYuRb8sQty0DytQKZEFR9+h4vomzKrg9l0aras=; b=iL8jicwDWeWj9nug0TmS4ZOYSElg03vxRPexry6+axLVwI0T9RLMoPPv+hmI0KmUHH yT3DoFnjSRyzi2F6lHDCu5rY9humWWaR7C4jg0MFfZ6potIHXEHI2JURfOiXIONKMJM+ Yn9NC12SJ1j8CwI+/cVzTNoUC2TpPciwX6qqKGqCLUTYR59c7wmtmo3h8mkvMmG8sQ1g s8/pRIIjZT3F7z1S0XPrvkEDFFQVb5ocEHYa/ixdBtcAgRsuzzvvTpYdL9pc4InJR46j /u+mqoFxUg0Ln0rxi8IeoAZWtp+pC9bb7OoANqOnOHkbFFgBqJtAAIAVWsKWRgyKcp8H YPLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=2454LkYuRb8sQty0DytQKZEFR9+h4vomzKrg9l0aras=; b=mowoRvKOkwBJeloHbp3fTlK2XPrSl8FFbhdtpP2LPFKAhLJtZ2UgYWLIFf4bQDIr9P 0KUPPTwdTBlrsPDnZozPbBOsCIvBDGR5cFg1HWQB7QWG9U1TWzBN8dpxGV7g4BqH1LQN zSSJdslKgTfDB/C4T8mfpdg3K1ZenJjJyGLYt5RghhHD8Hlt/OYyJLfXnctpLLVOGvbr sWIIZ2mNRtJ9+Xrgzm3ln+mPm7TxqdILrE/SAK/VEX5i5fjORZatTVAO6AjsnhTmPdo5 m3y2Bs2gwYZVNzq7yjL2/QynB0wiNeoDDWSMp1eSvpvwJ2sLt/QbftiSHnLkRbXTwNZt NDIg== X-Gm-Message-State: ALoCoQkiWgO4iT3qWrSGaBXG0fxi4Wt14K/5YqRxbdypQkpQS0hI8AXJ9/qe5AQ4l8vLB1gqivneZj8uzLYnPfj6+3uvu5QuPA== X-Received: by 10.28.225.6 with SMTP id y6mr7181419wmg.58.1449608328310; Tue, 08 Dec 2015 12:58:48 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id l7sm4573227wjx.14.2015.12.08.12.58.47 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Dec 2015 12:58:47 -0800 (PST) From: Thomas Monjalon To: Jan Viktorin Date: Tue, 08 Dec 2015 21:57:33 +0100 Message-ID: <2962709.1B5sjFu2MI@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151208215504.3c2de0c8@jvn> References: <1449602993-6047-1-git-send-email-viktorin@rehivetech.com> <12400151.dpjLSRpzoz@xps13> <20151208215504.3c2de0c8@jvn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [[RFC PATCH]] lib/ether: fix 16-bit unaligned access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 20:58:48 -0000 2015-12-08 21:55, Jan Viktorin: > On Tue, 08 Dec 2015 21:30:03 +0100 > Thomas Monjalon wrote: > > > 2015-12-08 20:29, Jan Viktorin: > > > (I considered to not add the cover-letter as this is just a single small patch. > > > I hope it does not matter a lot. Is there any convention how to do this?) > > > > The main interest of splitting patches or adding a cover letter it to have > > a place to explain the changes. When you have several changes, they deserve > > several patches to provide an accurate explanation. In such case, you may > > need a cover letter to describe the global idea of the series. A cover letter > > is also helpful for mail threading and acking all the series. > > When you have only one change, one email is enough. > > That's good. Should there be a way how to separate the "inline-cover" > and the commit? Do you mean how add a comment which won't be in the git tree? You can put whatever between the 3 dashes and the diff.