From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 677647CB0
 for <dev@dpdk.org>; Wed, 24 Oct 2018 16:33:32 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 06A2421C86;
 Wed, 24 Oct 2018 10:33:32 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 24 Oct 2018 10:33:32 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=ONcG9d5KTbUv90xNdFhjeZOybdMgrEHCO8Gzp6xF4tw=; b=qCN7r3z7ZYPj
 tCGWqKrH6McTuylFMyNpkj4Jard8IhPd0wZobJnW45QwdgzsyMNXY1/OP0hO9ImO
 pUqlUodFs9KXH/O/oa5qiMip0cW7qXtGXjGOZgA8P+rgpeenYZdCtIn7NJYPmP59
 BeDy4yPePZn9q6TJCf2Wj1Bk0aEmt1c=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=ONcG9d5KTbUv90xNdFhjeZOybdMgrEHCO8Gzp6xF4
 tw=; b=PZgZXViQP6PcZxlaNiXq1OUQLLE8DHGccAotMOpQtBbs6480oHmvdYgmR
 m/+DkaF87HvhVsHCe7d0HRZK75qOkJhsZxb373EPGm3AzqtttoODwj9lS1w1/lEr
 1smwkLX7UwV3aXJL6T1aI8t4neeOv/1aivh9GH3IPwVj/MZ3fqAikwj8ziuGa+8A
 gv9YZJF7af2hI4DE+p7jda5gyS4S3D1N4xQcsH62X8sE6AeIQr5vqJWKdGKm0Mt7
 s7mxOUakj/zjx9As2+4Wmqhtz1BCsmJz07U4lqaf2FkLBz52qUnccZpfGUOZmTeg
 lU3PhwJyRtUWMHgoQmnsg+bzdFwsg==
X-ME-Sender: <xms:uoLQWzhaW0qOGfxeoawHb34Ih73KxKNJTfLn2mEEERQFvzSn49rjQQ>
X-ME-Proxy: <xmx:uoLQW42jRIH1VYhHvhQ4FnNG-csCvbOCCKhT_AVFqthLABLoRvIeeA>
 <xmx:uoLQW5M7W02W_HPl-qGvdgtqw3dVN94daiyf2o0wSdogE21pZgPJ2A>
 <xmx:uoLQWznAPUePFm2uc_hjahbqOtYGCjo16r3DJn18_l5Jtl77FY4gKA>
 <xmx:uoLQW_oc5cJ6FKhr3XgmJ061TMMX8KCzPlAUlzD9bXdMReFdZD5V8A>
 <xmx:uoLQWwPgNOZfR0d1ZutrKQOm4N5qlTRfGZD0acqUMKONDJDnsg-n9Q>
 <xmx:u4LQWz4O8CYbbCWhNnuqX_hMFGkE_X-wjrz2GKhpuFnWoS1NbJW8ZQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id DD069E4119;
 Wed, 24 Oct 2018 10:33:29 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: =?ISO-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>, dev@dpdk.org,
 harry.van.haaren@intel.com, stephen@networkplumber.org, shreyansh.jain@nxp.com,
 mattias.ronnblom@ericsson.com, bruce.richardson@intel.com
Date: Wed, 24 Oct 2018 16:33:33 +0200
Message-ID: <29630789.dO8WeQshWb@xps>
In-Reply-To: <20181024140156.x4vyur6zxtbrrtny@bidouze.vm.6wind.com>
References: <20181022110014.82153-1-kevin.laatz@intel.com>
 <20181024132725.5142-2-kevin.laatz@intel.com>
 <20181024140156.x4vyur6zxtbrrtny@bidouze.vm.6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Subject: Re: [dpdk-dev] [PATCH v7 01/13] eal: add option register
	infrastructure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 14:33:32 -0000

24/10/2018 16:01, Ga=EBtan Rivet:
> Hi Kevin,
>=20
> On Wed, Oct 24, 2018 at 02:27:13PM +0100, Kevin Laatz wrote:
> > This commit adds infrastructure to EAL that allows an application to
> > register it's init function with EAL. This allows libraries to be
> > initialized at the end of EAL init.
> >=20
> > This infrastructure allows libraries that depend on EAL to be initializ=
ed
> > as part of EAL init, removing circular dependency issues.
> >=20
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> > Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
>=20
> I think this is good enough,
>=20
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Yes it looks good enough.
And it compiles fine in my test.

> The only remaining issue is rte_option_init().
> Sorry I missed your previous message and did not respond in time, I
> would have opted for leaving a return value to at least be able to stop
> the init on error. It is possible to force the callback type to return
> an error value along with a string / hint describing the error. It
> should not be hard to add it later, so not blocking IMO.

I think you need to set this API as experimental.