From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 780F258C3 for ; Tue, 10 Nov 2015 15:17:48 +0100 (CET) Received: by wmvv187 with SMTP id v187so10135639wmv.1 for ; Tue, 10 Nov 2015 06:17:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=5nKrHlLc1DZeuw1luPYdfF4BHqFVNh0Ts0/SuxybnEM=; b=B9pagGcNrCXBM9tc1pPAADfH4T2WclxRBI7xRcWVkk2Uzg3uX5n7YtXX9HIU2buOL0 GNNdNQwKV4iWfLZtfbOqDYm3biZqrLPw4+YP5m+867YCMH7y4Mng25ySzn5jnmJ44mSx NCYuzu/uB5nO+6wIshyoL/AnQxYkvEVYjjMFof7GbsWI6pN2iRfqy8bA/kNdTkdNKfOY hMWBwTeviTjIGdIbvxpRd1L8vapVpggDFVr5Nrtb22fVLK9k+6nI2wml347p5UpdFwSO sNxGx9P0+waH6RF4hYl8Y00vFyYn9mnoDSUKsFOzzxGqBaDWHrARC6AigFZZ6bqJEefl Lpkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=5nKrHlLc1DZeuw1luPYdfF4BHqFVNh0Ts0/SuxybnEM=; b=EGYC7vx3fDx18pD5zSQ2OwJEXRnwzRp67268fRLxc1JHUyf6CGUXXRgC9Kb//J7Tiw kPaHoEn9qrgUSJgW5HnnUmbMqRCobie3+3FJ+fdDECu0NaJENxWBfo61DTpPRVQ8Y/xn MfrUzFVlBNfgxZCCMQk1Vg8lUDK6NLWkt2RppMYo9VqtfFd3CLPoaxr5BHNnraxZLfQP wFnrQR4PNi7lUj6YR7RLRvORWdd8xO6w4sawRecZTj+rfd2fq+1LBX+/2oIYJx2MEaji 8SKzkjVumBPtslsGTGjcQLU4+w+I+tc5VxdGiuxq3SiWfxVSaUIT7QsXjJfLvuQwsNJ2 douQ== X-Gm-Message-State: ALoCoQkhB9VBVqswDljce0loVVZoZjMeqiUf2qPh78f9CIQW2a4D5DbXLPM8yfglEgL/Nzge2O3z X-Received: by 10.194.93.34 with SMTP id cr2mr5074107wjb.76.1447165068186; Tue, 10 Nov 2015 06:17:48 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id v9sm3730384wjv.45.2015.11.10.06.17.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 06:17:47 -0800 (PST) From: Thomas Monjalon To: "Mcnamara, John" Date: Tue, 10 Nov 2015 15:16:36 +0100 Message-ID: <2966972.cxZfc4bbJ0@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1443799208-9408-1-git-send-email-danielx.t.mrzyglod@intel.com> <3893351.MZRdjpoyuB@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 1/7] ethdev: add additional ieee1588 support functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 14:17:48 -0000 2015-11-10 14:12, Mcnamara, John: > My preference would be for verb_noun but I think noun_verb was used for consistency with the rest of the Ethdev API (although that isn't quite consistent either). And yes, read() would be more consistent with the timesync API while get() is more consistent with the rest of the Ethdev API. I think it would be best, in this case, to try maintain self-consistency and use rte_eth_timesync_read_time(). Yes, self consistency seems a good option.