From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9D9191B5B7; Wed, 17 Apr 2019 10:34:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CF95C23BEA; Wed, 17 Apr 2019 04:34:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 17 Apr 2019 04:34:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=LQqYUxPWm9hR0wB30b27fYKYzaaXsUBvB6u/1YEzw1g=; b=D0v1yqpQ12K+ fwsSYgDi4N//KEderufatSbv2P6+h9nHaG8Rk1rJypl612rR2rpePRL+WOIzSlBZ 3wmlBhBnr8HVXRI5AfRJYTyBtvZx2YG6LetE9Q5g4mjeSZCVbqFOm8oh50hHlMG0 zwsVbYQSWtPJfBVWr30rbHOO+E4Vj0s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=LQqYUxPWm9hR0wB30b27fYKYzaaXsUBvB6u/1YEzw 1g=; b=lDrIFSqhIMdZlr7a9UvvBFfrCzX7kMMl+Y51RdpGcC0tr5cgA+HJW1Trg P074UoGAvTJVUN87L/OANbMIpTDU8/rFuoQnUXZlYzlqCYfkqXRjvYYPyQ1cbbHV d9xvJFZw6kcoM2SK7tL10toS4u/PvJ3dNfZ9KTJa7cA2865MeZhcg1pemrhVRtKR /TxyGF8e8wXMO1sQJHO3Rsdrud/LK5h7z3/SKvW30ts2PoES7nAiTVcF+cUP8BNe 4phZQeOH2n2sD9uH8Z0a+JiHEK91OU94I9dMK2yqs3r8+7OLbT7r53SUwoq1F7zC +oqTbf9OR7G2CCENQZN8hx9AnRJfw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeefgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 31F0D103C9; Wed, 17 Apr 2019 04:34:53 -0400 (EDT) From: Thomas Monjalon To: viveksharma@marvell.com Cc: dev@dpdk.org, ferruh.yigit@intel.com, arybchenko@solarflare.com, stable@dpdk.org Date: Wed, 17 Apr 2019 10:34:50 +0200 Message-ID: <2967249.IQ5QtALfrT@xps> In-Reply-To: <1555486846-20764-1-git-send-email-viveksharma@marvell.com> References: <1555240302-9771-1-git-send-email-viveksharma@marvell.com> <1555486846-20764-1-git-send-email-viveksharma@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix QinQ strip offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 08:34:56 -0000 17/04/2019 09:40, viveksharma@marvell.com: > From: Vivek Sharma > > Enable missing support for QinQ strip rx offload > in vlan offload set/get methods. > > Fixes: cc9d0456b870 ("i40e: support double vlan stripping and insertion") > Cc: stable@dpdk.org Not sure it is a fix. The commit mentioned above allows some kind of offload config. You are extending the offload config with support in rte_eth_dev_set_vlan_offload(). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0D329A00E6 for ; Wed, 17 Apr 2019 10:35:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A1E01B5C1; Wed, 17 Apr 2019 10:34:58 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9D9191B5B7; Wed, 17 Apr 2019 10:34:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CF95C23BEA; Wed, 17 Apr 2019 04:34:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 17 Apr 2019 04:34:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=LQqYUxPWm9hR0wB30b27fYKYzaaXsUBvB6u/1YEzw1g=; b=D0v1yqpQ12K+ fwsSYgDi4N//KEderufatSbv2P6+h9nHaG8Rk1rJypl612rR2rpePRL+WOIzSlBZ 3wmlBhBnr8HVXRI5AfRJYTyBtvZx2YG6LetE9Q5g4mjeSZCVbqFOm8oh50hHlMG0 zwsVbYQSWtPJfBVWr30rbHOO+E4Vj0s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=LQqYUxPWm9hR0wB30b27fYKYzaaXsUBvB6u/1YEzw 1g=; b=lDrIFSqhIMdZlr7a9UvvBFfrCzX7kMMl+Y51RdpGcC0tr5cgA+HJW1Trg P074UoGAvTJVUN87L/OANbMIpTDU8/rFuoQnUXZlYzlqCYfkqXRjvYYPyQ1cbbHV d9xvJFZw6kcoM2SK7tL10toS4u/PvJ3dNfZ9KTJa7cA2865MeZhcg1pemrhVRtKR /TxyGF8e8wXMO1sQJHO3Rsdrud/LK5h7z3/SKvW30ts2PoES7nAiTVcF+cUP8BNe 4phZQeOH2n2sD9uH8Z0a+JiHEK91OU94I9dMK2yqs3r8+7OLbT7r53SUwoq1F7zC +oqTbf9OR7G2CCENQZN8hx9AnRJfw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeefgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 31F0D103C9; Wed, 17 Apr 2019 04:34:53 -0400 (EDT) From: Thomas Monjalon To: viveksharma@marvell.com Cc: dev@dpdk.org, ferruh.yigit@intel.com, arybchenko@solarflare.com, stable@dpdk.org Date: Wed, 17 Apr 2019 10:34:50 +0200 Message-ID: <2967249.IQ5QtALfrT@xps> In-Reply-To: <1555486846-20764-1-git-send-email-viveksharma@marvell.com> References: <1555240302-9771-1-git-send-email-viveksharma@marvell.com> <1555486846-20764-1-git-send-email-viveksharma@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix QinQ strip offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417083450.bQqeTqx1HzdTbfdq0_tnjiRxfTws2IjXUzV412xpCp8@z> 17/04/2019 09:40, viveksharma@marvell.com: > From: Vivek Sharma > > Enable missing support for QinQ strip rx offload > in vlan offload set/get methods. > > Fixes: cc9d0456b870 ("i40e: support double vlan stripping and insertion") > Cc: stable@dpdk.org Not sure it is a fix. The commit mentioned above allows some kind of offload config. You are extending the offload config with support in rte_eth_dev_set_vlan_offload().