From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 70DA94C8F for ; Sun, 18 Nov 2018 23:04:31 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EBF6E21D39; Sun, 18 Nov 2018 17:04:30 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 18 Nov 2018 17:04:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=WeIvykMkOQplKuz20EudTyiz5a/JN9MEXhPd7kB8spA=; b=pNX4BqeSG2Hd DJdX7WMhyUxu0xpxtXK+zF35/n2VvfpTzm3bFrx/m6t7FOPh7EcQkaeH15JYXtv0 ctCASf9zN+7YFMqfLmhPolWysDkijBOV0haWW+mMEBAezW7uFotYY0wzi/w9dduA LsGiYJHm8jHMfGUN4L/MNenNBPUET2Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=WeIvykMkOQplKuz20EudTyiz5a/JN9MEXhPd7kB8s pA=; b=u6wi0QhgoTZaZmngKR8eunirF9AQFKX0cPmZ66pWKX3KeOTo/fYrw9IM7 1fcPyNMSp1LkIYGZ6axmJZ46aDD2ANCl+NBN0dPn3ESyXk6cIpZETTHVH3H3ELWB QQo5GVa2schIIpN5GqJegHfo84BhvewLK03cYe+GzobF3AnyTxUuIc52CaYtG6oB fr/mpumvjHOxhJqByhtDyTStj/JvHFBMmu4M9b+n2K/JIaNFoBBrAIdct0RwiW/C nJUYbujSNlU8799VV+MPyTq22rRkooslAQeZSNo4v3yF0aNUK/pgCkIiFfb0kpJu s2ZMve7IhfU5I7og8rnZ4EU0BWCXA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9F12C102DE; Sun, 18 Nov 2018 17:04:29 -0500 (EST) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, shuaix.zhu@intel.com Date: Sun, 18 Nov 2018 23:04:28 +0100 Message-ID: <2967934.jiZKzRrys8@xps> In-Reply-To: <532f05a13228ffd85931807dd4aa2384a27b7da4.1542283782.git.anatoly.burakov@intel.com> References: <532f05a13228ffd85931807dd4aa2384a27b7da4.1542283782.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test: fix eal flags autotest hugepage file handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2018 22:04:31 -0000 15/11/2018 13:18, Anatoly Burakov: > Before 18.05, DPDK could not release memory back to the system > neither at runtime nor before shutting down. Over the course of > 18.05 up to 18.11, code was introduced to release memory at > runtime, as well as an rte_eal_cleanup() function that is supposed > to release all EAL-allocated memory before shutting down DPDK. > > When 3f9e31d71d63 ("test: clean up on exit") was introduced, the > test application started to use rte_eal_cleanup() to release all > used memory after execution. However, the EAL flags autotest > still relies on the old behavior of leaving stuff behind in the > hugetlbfs. > > The fix is twofold. First, the test to check for leftover files > in hugetlbfs is no longer valid as it is, because test application > now removes all files from hugetlbfs after exit. However, if we > use the --legacy-mem option, then old behavior of leaving files > in hugetlbfs after execution is restored. So the first fix is to > add --legacy-mem to all the tests that expect files in hugetlbfs > to be leftover. > > However, we also need to test if default memory mode *doesn't* > leave any files behind, so we also extend the test to check for > these scenarios as well. So, both memtest1 and memtest2 are run > in legacy and default mem modes, and are checked for any leftover > files that are or are not supposed to be there. > > Fixes: 3f9e31d71d63 ("test: clean up on exit") > > Signed-off-by: Anatoly Burakov I guess you know what you are doing :-) Applied, thanks