DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: gaetan.rivet@6wind.com
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix reported device info
Date: Fri, 7 Jun 2019 11:58:27 +0100	[thread overview]
Message-ID: <296f3374-cd02-c758-674e-1e61f84d0c3c@intel.com> (raw)
In-Reply-To: <20190516035310.31145-1-stephen@networkplumber.org>

On 5/16/2019 4:53 AM, Stephen Hemminger wrote:
> The failsafe driver device info had several issues in the
> info it reported in dev_info_get:
>   - it cleared dev_info->device set in rte_eth_dev_info_get
>   - many fields (for example max_rx_queue) should be the minimum
>     of all sub devices
>   - it reported tx capa for the active transmit device, but
>     the device may change.
> 
> There was enough messed up that ended up reworking the info_get
> handler. There is no need to save current values or have a
> template for defaults.
> 
> Fixes: 4e31ee26ed51 ("net/failsafe: report actual device capabilities")
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

Hi Gaetan,

Reminder of this patch waiting for your review.

Thanks,
ferruh


  parent reply	other threads:[~2019-06-07 10:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  3:53 Stephen Hemminger
2019-05-16  3:53 ` Stephen Hemminger
2019-06-07 10:58 ` Ferruh Yigit [this message]
2019-06-07 12:18   ` Gaëtan Rivet
2019-06-07 16:36     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=296f3374-cd02-c758-674e-1e61f84d0c3c@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=stephen@networkplumber.org \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).