From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74E01A0C41; Tue, 11 May 2021 09:41:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02E5940140; Tue, 11 May 2021 09:41:33 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 0803C4003E; Tue, 11 May 2021 09:41:31 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7C2785C0066; Tue, 11 May 2021 03:41:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 11 May 2021 03:41:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= gSCbN7j32d2oYoae4zGZ1a6EUcdqcYurvlRpCdMPPwo=; b=IT0WqNVMt0R7wxnP 0BdVopm6TNrdShPXzeZZmfAFkSY5P42hRe8VWfJmlcoK8Yvv21uWjzQBYar2A0dl /+NOQ2LI5606FQH0WzOqNVxsVb1OVjJwM7b/CkLkdvSoExr58fi6Nerp26oxklzy lntOQdW8PnakVVJ3HSdhp4+Bkh0PZr7RfQUXPztG5AOxrmzZ/9nYWuPIYZV6w0cx GkmioCRSqHyvZ55nqGIRnymQyXhX0ekPF5cnxs9ppnRlIUvtUBrjOK9fWn17c+ry tIGB2WNtw7iQHo3TUYWduaIJfe5nCRXolGKUuMp8MNhz4q7P3PyQWUsJeoZHWpbE lW9VdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=gSCbN7j32d2oYoae4zGZ1a6EUcdqcYurvlRpCdMPP wo=; b=AJDik9uIsKXf2lnnNkzS29irVmJDpJIaBs1fm5g9Hmclej1/dzmwpcBmB QBr2nZ9vskpK+HBfBs+mXuGL7/omKDmGb4uLw24W3QH69tk49cX7Jb4f92k9NSEM ppSz6YonT/saE8aIhxYMGKlZwyjg32I8tkvQ6XtL4bUqLrigSnOZnOMog8n+dZT1 FM764pIpgJ/I+F8nxnwxswr+j1dzaGVvUB4pWKKsdkljiy2aac+x1ob5eVZcFus+ iQvLi7wxtf4pE1PG0bUAB7w9uGrQmMTkR2Z1fI7l+FsYtj7UYB5AtmGL6XzlNFC/ 2imDUEkmdU0dKiGKNojaXkD1iNPpg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegledguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 May 2021 03:41:30 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Dmitry Kozlyuk , stable@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Harman Kalra , Harini Ramakrishnan , ranjit.menon@intel.com Date: Tue, 11 May 2021 09:41:28 +0200 Message-ID: <2970635.tDqZXrgMp7@thomas> In-Reply-To: <20210502023333.30351-3-dmitry.kozliuk@gmail.com> References: <20210502023333.30351-1-dmitry.kozliuk@gmail.com> <20210502023333.30351-3-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] eal/windows: cleanup interrupt resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/05/2021 04:33, Dmitry Kozlyuk: > Interrupt manager in Windows EAL allocates on IOCP and starts > a control thread that runs indefinitely. At DPDK cleanup > this thread was not stopped and IOCP handle was not closed. > > Gracefully stop interrupt-handling in rte_eal_cleanup(). > The thread already closes IOCP handle before exiting. > > Fixes: 5c016fc0205a ("eal/windows: add interrupt thread skeleton") > Cc: stable@dpdk.org > > Signed-off-by: Dmitry Kozlyuk > --- > lib/eal/windows/eal.c | 1 + > lib/eal/windows/eal_interrupts.c | 26 ++++++++++++++++++++++++-- > lib/eal/windows/eal_windows.h | 5 +++++ > 3 files changed, 30 insertions(+), 2 deletions(-) It seems nobody reviewed. To be on the safe side, I'll merge this series after DPDK 21.05 is released. Or am I missing any critical issue?