From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 755983772 for <dev@dpdk.org>; Thu, 28 Mar 2019 16:10:09 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0CEC821FB7; Thu, 28 Mar 2019 11:10:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Mar 2019 11:10:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=y+3EmdKeGTxsYPQ/4b0WUGhrNxFwExhPGzklREpH2IY=; b=m5uefaUmzugb HI5pgWjdBQziK/RY/QvlG1FHPEnvjD9Xki2tqPi5/Fjcs1XnLj7qC6A5bYR7bf6p H+DI6rsLn1knfRayBDAAWaFIClu8qFzNjoZC093B+KeSaNnjLnwaocrXxmK5Wq68 jWFrXFq39fhZJAxvU64i1Okr/Q9Q35Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=y+3EmdKeGTxsYPQ/4b0WUGhrNxFwExhPGzklREpH2 IY=; b=cn2TEWuodriJnqGNk022zRBY4Xo/eUspszIsw56NUqQsr/WpwO1Nfaldg LjBVpoOXEwnml1jfltBxoJNvcv3zjJ0mvjiYXOU+YngzkKgokqEMBzkoWIILpSGU hbSuciquEREUjsKC/mR3JGQk7C4HnfU6y/PD7PFNyOBQO0A/wV3ZwF8yu9lZgdXf OBF/XCWoRD6QQ4jRBWLlD6/3lGVXh7FsgpSWtK92qClc9QTfGL/nu3l1T2AsNDk+ th45Cwdsgsr46gG0PccUf/nfv+qpkQgxRCpOYxJ1Pv92BY7nBeS6Exn52B2St9Ff 9anEwX849sQLl+e1rxcziN56cysIA== X-ME-Sender: <xms:z-OcXM2ve2hvkd-D93aIWtUGXyz_o6YDef_w4MA006geQ3DRUwxWKQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeeggdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:z-OcXLX9vBS8t0lOZUggULWge4SRLdvAKdJDdMLG2nHkW8PArb38cw> <xmx:z-OcXP6Q7zp4xiuy2oQPZ1G7VNRkNABNC_GQnsHZR_V-ZS59Hj5bqg> <xmx:z-OcXKL5a1EuUyUHSz_UHpsG9XiA8iiBrnXYtC0rexQ373eyT3fvpg> <xmx:0OOcXHHqa1YR_Xisb3Ju3ADw15nHjMHBA4DKbp1f6LNKT5MNW3IFZA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E8A5210319; Thu, 28 Mar 2019 11:10:06 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Anand Rawat <anand.rawat@intel.com>, pallavi.kadam@intel.com, ranjit.menon@intel.com, bruce.richardson@intel.com Cc: dev@dpdk.org, jeffrey.b.shaw@intel.com Date: Thu, 28 Mar 2019 16:10:04 +0100 Message-ID: <2972503.EZJb3jvalo@xps> In-Reply-To: <20190328022115.4660-9-anand.rawat@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328022115.4660-1-anand.rawat@intel.com> <20190328022115.4660-9-anand.rawat@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 8/8] build: meson changes to build on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 28 Mar 2019 15:10:09 -0000 28/03/2019 03:21, Anand Rawat: > Added meson workarounds to build helloworld on windows. > Windows currently only supports kvargs and eal libraries. > This change restricts the build flow to supported libraries > only. It is OK to merge few limited workarounds in the master branch, in order to start compiling something on Windows, and regularly check that the work done is not broken by other patches coming in. It will be especially useful if we manage to have a CI for Windows. > --- a/lib/librte_eal/common/meson.build > +++ b/lib/librte_eal/common/meson.build > common_objs = [] > +common_sources = files( > + 'eal_common_errno.c', > + 'eal_common_launch.c', > + 'eal_common_lcore.c', > + 'eal_common_log.c' > + ) > +if host_machine.system() != 'windows' > common_sources = files( > 'eal_common_bus.c', > 'eal_common_cpuflags.c', > 'eal_common_class.c', > 'eal_common_devargs.c', > 'eal_common_dev.c', > - 'eal_common_errno.c', > 'eal_common_fbarray.c', > 'eal_common_hexdump.c', > 'eal_common_hypervisor.c', > - 'eal_common_launch.c', > - 'eal_common_lcore.c', > - 'eal_common_log.c', > 'eal_common_memalloc.c', > 'eal_common_memory.c', > 'eal_common_memzone.c', > @@ -38,6 +41,7 @@ common_sources = files( > 'rte_reciprocal.c', > 'rte_service.c' > ) > +endif As discussed over the phone, it would be better to overwrite this list and keep the original one as is. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9F979A0679 for <public@inbox.dpdk.org>; Thu, 28 Mar 2019 16:10:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B78561B130; Thu, 28 Mar 2019 16:10:10 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 755983772 for <dev@dpdk.org>; Thu, 28 Mar 2019 16:10:09 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0CEC821FB7; Thu, 28 Mar 2019 11:10:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Mar 2019 11:10:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=y+3EmdKeGTxsYPQ/4b0WUGhrNxFwExhPGzklREpH2IY=; b=m5uefaUmzugb HI5pgWjdBQziK/RY/QvlG1FHPEnvjD9Xki2tqPi5/Fjcs1XnLj7qC6A5bYR7bf6p H+DI6rsLn1knfRayBDAAWaFIClu8qFzNjoZC093B+KeSaNnjLnwaocrXxmK5Wq68 jWFrXFq39fhZJAxvU64i1Okr/Q9Q35Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=y+3EmdKeGTxsYPQ/4b0WUGhrNxFwExhPGzklREpH2 IY=; b=cn2TEWuodriJnqGNk022zRBY4Xo/eUspszIsw56NUqQsr/WpwO1Nfaldg LjBVpoOXEwnml1jfltBxoJNvcv3zjJ0mvjiYXOU+YngzkKgokqEMBzkoWIILpSGU hbSuciquEREUjsKC/mR3JGQk7C4HnfU6y/PD7PFNyOBQO0A/wV3ZwF8yu9lZgdXf OBF/XCWoRD6QQ4jRBWLlD6/3lGVXh7FsgpSWtK92qClc9QTfGL/nu3l1T2AsNDk+ th45Cwdsgsr46gG0PccUf/nfv+qpkQgxRCpOYxJ1Pv92BY7nBeS6Exn52B2St9Ff 9anEwX849sQLl+e1rxcziN56cysIA== X-ME-Sender: <xms:z-OcXM2ve2hvkd-D93aIWtUGXyz_o6YDef_w4MA006geQ3DRUwxWKQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeeggdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:z-OcXLX9vBS8t0lOZUggULWge4SRLdvAKdJDdMLG2nHkW8PArb38cw> <xmx:z-OcXP6Q7zp4xiuy2oQPZ1G7VNRkNABNC_GQnsHZR_V-ZS59Hj5bqg> <xmx:z-OcXKL5a1EuUyUHSz_UHpsG9XiA8iiBrnXYtC0rexQ373eyT3fvpg> <xmx:0OOcXHHqa1YR_Xisb3Ju3ADw15nHjMHBA4DKbp1f6LNKT5MNW3IFZA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E8A5210319; Thu, 28 Mar 2019 11:10:06 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Anand Rawat <anand.rawat@intel.com>, pallavi.kadam@intel.com, ranjit.menon@intel.com, bruce.richardson@intel.com Cc: dev@dpdk.org, jeffrey.b.shaw@intel.com Date: Thu, 28 Mar 2019 16:10:04 +0100 Message-ID: <2972503.EZJb3jvalo@xps> In-Reply-To: <20190328022115.4660-9-anand.rawat@intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328022115.4660-1-anand.rawat@intel.com> <20190328022115.4660-9-anand.rawat@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 8/8] build: meson changes to build on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190328151004.SKBcyNThUUIdeX2i07Oi5YvX5X3nXXGZCHkNsNo3Fvs@z> 28/03/2019 03:21, Anand Rawat: > Added meson workarounds to build helloworld on windows. > Windows currently only supports kvargs and eal libraries. > This change restricts the build flow to supported libraries > only. It is OK to merge few limited workarounds in the master branch, in order to start compiling something on Windows, and regularly check that the work done is not broken by other patches coming in. It will be especially useful if we manage to have a CI for Windows. > --- a/lib/librte_eal/common/meson.build > +++ b/lib/librte_eal/common/meson.build > common_objs = [] > +common_sources = files( > + 'eal_common_errno.c', > + 'eal_common_launch.c', > + 'eal_common_lcore.c', > + 'eal_common_log.c' > + ) > +if host_machine.system() != 'windows' > common_sources = files( > 'eal_common_bus.c', > 'eal_common_cpuflags.c', > 'eal_common_class.c', > 'eal_common_devargs.c', > 'eal_common_dev.c', > - 'eal_common_errno.c', > 'eal_common_fbarray.c', > 'eal_common_hexdump.c', > 'eal_common_hypervisor.c', > - 'eal_common_launch.c', > - 'eal_common_lcore.c', > - 'eal_common_log.c', > 'eal_common_memalloc.c', > 'eal_common_memory.c', > 'eal_common_memzone.c', > @@ -38,6 +41,7 @@ common_sources = files( > 'rte_reciprocal.c', > 'rte_service.c' > ) > +endif As discussed over the phone, it would be better to overwrite this list and keep the original one as is. Thanks