DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] pci: fix missing off_t define on FreeBSD
Date: Tue, 17 Mar 2020 10:24:15 +0100	[thread overview]
Message-ID: <2973777.NnENhoQgcM@xps> (raw)
In-Reply-To: <20200316163705.5675-1-bruce.richardson@intel.com>

16/03/2020 17:37, Bruce Richardson:
> When removing the extra headers from rte_pci.h stdlib should have been
> removed instead of stdio, since off_t is missing for BSD builds when just
> including stdlib.h
> 
> Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header file")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Sorry, I missed the failure seen in the community lab:
	http://mails.dpdk.org/archives/test-report/2020-March/120862.html
Note: we should always wait for tests to be run.
Thank you for the quick fix.

Applied, thanks



      reply	other threads:[~2020-03-17  9:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-16 16:37 Bruce Richardson
2020-03-17  9:24 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2973777.NnENhoQgcM@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).