From: Thomas Monjalon <thomas@monjalon.net>
To: Volodymyr Fialko <vfialko@marvell.com>
Cc: dev@dpdk.org, Reshma Pattan <reshma.pattan@intel.com>,
jerinj@marvell.com, anoobj@marvell.com
Subject: Re: [PATCH 1/3] reorder: add new drain up to seq number API
Date: Mon, 20 Feb 2023 00:30:33 +0100 [thread overview]
Message-ID: <2975061.WAvfycf1tz@thomas> (raw)
In-Reply-To: <20230120102146.4035460-2-vfialko@marvell.com>
We are waiting for a detailed review.
The series could be merged without review.
Please fix cosmetic comments below and send a new version to check CI result.
20/01/2023 11:21, Volodymyr Fialko:
> Introduce new reorder drain API:
> `rte_reorder_drain_up_to_seqn` - exhaustively drain all inserted mbufs
> up to the given sequence number.
>
> Currently there's no ability to force the drain from reorder buffer,
> i.e. only consecutive ordered or ready packets could be drained.
> New function would give user ability to drain inserted packets, without
> need to wait for missing or newer packets.
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
[...]
> --- a/lib/reorder/rte_reorder.h
> +++ b/lib/reorder/rte_reorder.h
> @@ -167,6 +167,31 @@ unsigned int
> rte_reorder_drain(struct rte_reorder_buffer *b, struct rte_mbuf **mbufs,
> unsigned max_mbufs);
>
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> + * Fetch set of reordered packets up to specified sequence number (exclusive)
> + *
> + * Returns a set of in-order packets from the reorder buffer structure.
> + * Gaps may be present since reorder buffer will try to fetch all possible packets up to given
> + * sequence number.
> + *
> + * @param b
> + * Reorder buffer instance from which packets are to be drained.
> + * @param mbufs
> + * Array of mbufs where reordered packets will be inserted from reorder buffer.
> + * @param max_mbufs
> + * The number of elements in the mbufs array.
> + * @param seqn
> + * Sequence number up to which buffer will be drained.
> + * @return
> + * Number of mbuf pointers written to mbufs. 0 <= N < max_mbufs.
> + */
> +__rte_experimental
> +unsigned int
> +rte_reorder_drain_up_to_seqn(struct rte_reorder_buffer *b, struct rte_mbuf **mbufs,
> + unsigned int max_mbufs, rte_reorder_seqn_t seqn);
> #ifdef __cplusplus
blank line missing
> --- a/lib/reorder/version.map
> +++ b/lib/reorder/version.map
> @@ -16,4 +16,5 @@ EXPERIMENTAL {
> global:
>
> rte_reorder_seqn_dynfield_offset;
> + rte_reorder_drain_up_to_seqn;
Please add a comment "# added in 23.03" as we do in other libs.
next prev parent reply other threads:[~2023-02-19 23:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 10:21 [PATCH 0/3] reorder: introduce new APIs Volodymyr Fialko
2023-01-20 10:21 ` [PATCH 1/3] reorder: add new drain up to seq number API Volodymyr Fialko
2023-02-19 23:30 ` Thomas Monjalon [this message]
2023-01-20 10:21 ` [PATCH 2/3] reorder: add ability to set min sequence number Volodymyr Fialko
2023-01-20 10:21 ` [PATCH 3/3] test/reorder: add cases to cover new API Volodymyr Fialko
2023-01-20 12:43 ` Volodymyr Fialko
2023-02-19 23:32 ` Thomas Monjalon
2023-01-26 15:48 ` [PATCH 0/3] reorder: introduce new APIs David Marchand
2023-02-20 10:48 ` [PATCH v2 0/2] " Volodymyr Fialko
2023-02-20 10:48 ` [PATCH v2 1/2] reorder: add new drain up to seq number API Volodymyr Fialko
2023-02-20 10:48 ` [PATCH v2 2/2] reorder: add ability to set min sequence number Volodymyr Fialko
2023-02-20 11:01 ` [PATCH v2 0/2] reorder: introduce new APIs Thomas Monjalon
2023-02-20 15:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2975061.WAvfycf1tz@thomas \
--to=thomas@monjalon.net \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=reshma.pattan@intel.com \
--cc=vfialko@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).