From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 38C3A5677 for ; Mon, 8 Feb 2016 12:46:20 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id g62so129038544wme.0 for ; Mon, 08 Feb 2016 03:46:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=JHwH6+w8XU9bSe1XxOGcgDNmifnHEywnZKUSnXGQCz4=; b=mO8xTwQ3uxWUwpPwb2bekQBcrtIFDKtRQWGnp9UQ+1wLgYjJVzzI+PRopDRQkRSe6W 9BZnsmVzEFneKnv8DuSh/O7QhckPiKyKCXamfIZMc8Kl8HwItK7zkLKElxPhI58foMQh g6JVfn/ih13Abn48SkEp6PToAZUlRxsheOV09N6/EJKMae2WXlN/Gk9FgakJ9Hc2rlCM NlUqoxVkBvfCXPULPGcASrOX/k5rOLgkpaA/rT1kqmi4ScQ2UFo6TOoW2XVAc/sw8tV9 ejH89T9GARN08WXNJT/vh6BRsVQisuaF3A7jF+QcPqOYXb921v1ZBQebsTR1v5sBpIvY SsAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=JHwH6+w8XU9bSe1XxOGcgDNmifnHEywnZKUSnXGQCz4=; b=NJaRkp9nNOmlzjaHv4cxxw/DnRfl1H5DX/bBN2uwb3xMLz87cC/qpfB0w9/wgTW0rH UNznkUZbV7ZSK2fnsg9nY0v/iv4xYNVlfED+r1h6JwfkS020SLE3RstjVFi9nqDkdMFL G+YeT8w+HHIn0btHS3d7wOcwhH2TufcMa7KpwZjlItj9f3ipHu2wUZu9GMpjlLv06sZu 0dzgqgp2RUjCGioOXjuu36WUIiGfPzDj7L33aS03ePUjkk89P779PDL/H6KnZwcbdIRk NNLD5ET/mEkwV+588mVueCDIgj0Hqkoh8+FqQmCQ5KRwprxifDiBU+cf/3pot/u07nW9 Vmpw== X-Gm-Message-State: AG10YOSxvALbD3FIJVKS0BGu1GMOPA8214R32WoV1fweGVGIOXvYoJtDVLG1OQQN/+QRWmeG X-Received: by 10.28.65.193 with SMTP id o184mr48442682wma.15.1454931980052; Mon, 08 Feb 2016 03:46:20 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id q129sm12307586wmd.14.2016.02.08.03.46.18 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 08 Feb 2016 03:46:19 -0800 (PST) From: Thomas Monjalon To: Jerin Jacob Date: Mon, 08 Feb 2016 12:44:57 +0100 Message-ID: <2977549.PxuGhIR2Yb@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151208093333.GA3650@localhost.localdomain> References: <1449498170-19872-1-git-send-email-jerin.jacob@caviumnetworks.com> <1750446.FDPWrLgo55@xps13> <20151208093333.GA3650@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, viktorin@rehivetech.com Subject: Re: [dpdk-dev] [PATCH] config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2016 11:46:20 -0000 2015-12-08 15:03, Jerin Jacob: > On Mon, Dec 07, 2015 at 03:45:10PM +0100, Thomas Monjalon wrote: > > 2015-12-07 19:52, Jerin Jacob: > > > by default, all the targets will be configured with the 64-byte cache line > > > size, targets which have different cache line size can be overridden > > > through target specific config file. > > > > > > Selected ThunderX and power8 as CONFIG_RTE_CACHE_LINE_SIZE=128 targets > > > based on existing configuration. > > > > > > Signed-off-by: Jerin Jacob > > > > It looks good. > > We are moving from a constant defined on CC command line in most cases > > to a constant included in rte_config.h only. > > Have you checked that the generated libraries are identical? > > Yes, Tested with a 64byte(x86_64-native-linuxapp-gcc) and a 128byte > (arm64-thunderx-linuxapp-gcc) target. > md5sum build/app/test comes same with or without patch. > > > It would be good to have a check for POWER8. Chao? > > Thanks It seems we won't have a test on POWER8. Acked-by: Thomas Monjalon