From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 53C979601 for ; Fri, 13 May 2016 12:28:09 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id n129so16766529wmn.1 for ; Fri, 13 May 2016 03:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=3yCt2dZAt8eD+ThcvQubaWLDRFEKSE/J8qUbxN557D8=; b=nx7Ei9ao0O9l2D21GQGpF6Lz+DdzNBUOJ9YYFyav4FdLzaOk7oR/Sxay4VVFVpt6hc hYiZuwhrCAFnLFmwYSgbRRYNc0Y/c8gRIuTvUtewLPMAUP29NDYdF/qKbghu9Fu3Bbdr fnHmmedMDCcvA+c8EAR9hMjoW8j1twdXyC1FNMjm7BTeOwzbqvp+QsY3lZWxvKCXajR/ z0Wrdt7WxQpU+8v8EGZGOhvPoEpbkIVs8ttTG5t9t5ei8t5az5mRd5eDd1ZsY0czXfag 26cAk1Ib7Hl89QVPpd+zktMWD+3aaxrzvH9ei53ZeFZKj1kK+mw6pxq4KSBjTomoYEsT fRBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=3yCt2dZAt8eD+ThcvQubaWLDRFEKSE/J8qUbxN557D8=; b=XRdPtbYptfnkjUZMKLVg70D+Oh8zVSxU+B911cvNSCo6Q2mMz7gCgOu50b3sBliU1+ YpehEZ2/ZD2m2f6703Ma4yzZuK1Sr9lO25SQzV1krDajEDM8jRzlqpSjZhee+YVR9oli bzf14zK8fVn0L8bAoTX1uQ7q9ueDMsE7RWtc57NNxfX6cdXSFabM2XyGpXkTU4vQzUwC rhGZNOaVlXcGZilLOk5lTyHe7NnddVFNuwAJ5WBpzLlaV5YlzNJYvXz0PbQ7NNTjRzur EeLSl6b3ySxv5I9p+K40bIPJ2fLWSgqnPjoFxxKLDvHdSa/GFJgAJn/8Sw72BaM1P3ok ODUg== X-Gm-Message-State: AOPr4FU5aRa9q8GD53y0DaRWs4KRuRfEq15YKtHiwlPjl8OYQP9wDop/uJMQSFLowla2ltez X-Received: by 10.28.149.205 with SMTP id x196mr2989957wmd.67.1463135289129; Fri, 13 May 2016 03:28:09 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id g197sm2551655wme.15.2016.05.13.03.28.08 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 13 May 2016 03:28:08 -0700 (PDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy , Daniel Mrzyglod Cc: dev@dpdk.org, david.marchand@6wind.com Date: Fri, 13 May 2016 12:28:07 +0200 Message-ID: <2977689.TnkrfoPGVf@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <72463300-a846-43a7-11d4-65a48b6370d0@intel.com> References: <1462982465-129762-1-git-send-email-danielx.t.mrzyglod@intel.com> <72463300-a846-43a7-11d4-65a48b6370d0@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: fix resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2016 10:28:09 -0000 2016-05-12 08:55, Sergio Gonzalez Monroy: > On 11/05/2016 17:01, Daniel Mrzyglod wrote: > > Fix issue reported by Coverity. > > Coverity ID 97920 > > > > munmap structure of hugepage > > > > leaked_storage: Variable hugepage going out of scope leaks the storage > > it points to. > > > > The system resource will not be reclaimed and reused, reducing the future > > availability of the resource. > > I'm not really fond of this commit messages, but if no one minds them, > so be it. Me too. It looks like a Machine2Machine message. I'd prefer an explanation of what is wrong first, then an explanation of the fix, and at the end, the Coverity ID (can be a tag like Fixes-Coverity-ID: 97920). > > In rte_eal_hugepage_init: Leak of memory or pointers to system resources > > > > Fixes: b6a468ad41d5 ("memory: add --socket-mem option") > > > > Signed-off-by: Daniel Mrzyglod