From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f174.google.com (mail-we0-f174.google.com
 [74.125.82.174]) by dpdk.org (Postfix) with ESMTP id 0C7E71F7
 for <dev@dpdk.org>; Mon, 23 Mar 2015 12:10:26 +0100 (CET)
Received: by webck51 with SMTP id ck51so7940470web.2
 for <dev@dpdk.org>; Mon, 23 Mar 2015 04:10:25 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=0zCMk4Jz+PJxA9qeOFE53Xfz+zAFv/gcD9OA32y4qWY=;
 b=eUzIOa4U8N9aTid5lDyEeavqZZDkKNrW7BfVundHcw1giNXdSclPAf0BZwiZ67roZd
 pdydxoynTLL7YokVYhIjXo2Cr43flnDk55RuErem45cC1MZBjFEn1vgsrhJYYOi9pxOm
 UWnbVzg+oRtsvCCZABadDvru0GhIVXZr6XngQNHC88Ao9uAyvkkC6MlIVCR5kvc4bCzC
 n9OT0JKaZ9I9sQ9+PPd6GYK6IAJf0mADc+QxgmutxSBJM9PlcC/7z0H6rYozuBXnfFZR
 2DGwkyx7I/QTVDAbPbX2QTJqJtB13q2Z6w2pYO3tFT3W8xS+IOX+uFHmcWL/f1yBreBC
 jc9A==
X-Gm-Message-State: ALoCoQm053wmXVmmiudicq9p+Ext8I5m1ss+U6nyW5SqWGP6AcIfBhKshYeUItn/sd5Tc7G2SmF6
X-Received: by 10.180.7.136 with SMTP id j8mr9228341wia.10.1427109025856;
 Mon, 23 Mar 2015 04:10:25 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id ge8sm860745wjc.32.2015.03.23.04.10.24
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 23 Mar 2015 04:10:25 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Andre Richter <andre.o.richter@gmail.com>
Date: Mon, 23 Mar 2015 12:09:45 +0100
Message-ID: <2986196.1mfTVxFWUh@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <1426691107-7399-1-git-send-email-andre.o.richter@gmail.com>
References: <1426691107-7399-1-git-send-email-andre.o.richter@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] tools: Fix some strings and functions
	regarding VFIO support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Mar 2015 11:10:26 -0000

Hi,

Your patch looks good.
Please could you resend it with a Signed-off-by line?
Procedure is described here:
	http://dpdk.org/dev#send

Thanks

2015-03-18 16:05, Andre Richter:
> This patch fixes several minor issues in setup.sh:
> 
>      - show_nics() would not display the current Ethernet settings if
>        the user only loads the vfio-pci module, b/c it only checks for
>        presence of igb_uio. Fix this by adding a check for vfio-pci.
> 
>      - unbind_nics(): Fix option naming and string inside function.
> 
>      - Exchange a forgotten "igb_uio" with "vfio-pci" in a comment.